@DataDrake I was not aware of this native git support, I think it was not there before. Any way good to know it's there.

In T949#15558, @DataDrake wrote:

Doing an arbitrary git clone like that is not okay. Rebuilds of a package must always use the same source code. This has the potential to use a different version of the code revision each time you rebuild.

@DataDrake We need sdk files to compile the client. In fact we are using sdk as a source.

@theSoenke thanks for the heads-up, I actually forgot to sort. I am not sure about %autogen macro also. AFIK install command is not meant for copying entire folder. If there are any workarounds let me know.

@DataDrake Is this being reviewed ?

Please check this patch file with new sdk release:

@nunomgsantos issue opened for tagging remain unnoticed by mega devs, any fix with git source won't be appropriate.

2.5.0 is pretty outdated. (Not compatible with new releases of MegaSync)

Will it be ok to fetch a specific commit then ?

any news on this ? :/

still awaiting fixes?

@theSoenke cool.
looking forward to see this in repos.

@theSoenke no offence, LGTM :) . BTW, can you share some info on the improvements ?

@theSoenke is it failing while building? it seems working fine with me.

I think this task can be closed now.

-D_FORTIFY_SOURCE was added in CFLAGS by default, setup was failing and showing that it's a CPPFLAG, not a CFLAG. so i added it as CPPFLAG, and removed from CFLAGS.

It is my pleasure.

:D happy.

I am happy that you guys found it useful, for me rofi is a must have utility since i am not a mouse guy (was really waiting for i3 to come). Here is the required patch, but did from scratch (just to verify the deps once more).

Cool. I am ok with it. Is this a packaging principle, that we focusing on less in number but robust alternatives ? Just asking .

It is already in unstable. Packaged it as a dependency for rofi. This task can be deleted. Lack of research from my side.

Since we packaged i3wm, rofi is an advanced window switcher and dmenu replacement for i3, will work as a launcher for any DE though.

I think this task can be peacefully closed now.

Instincts !

Thanks for explaining the diff, its indeed a great utility. :)

removed python rundep :)