@JoshStrobl Thanks for the review, I removed the unwanted files as requested

Removed unwanted files as requested by @JoshStrobl

@Staudey Thanks for your quick review, no worries to abandon my version 😄

Instead of installing borgmatic as a Solus package, it can be easily installed via pipx, which is available as Solus package.

Hi @EbonJaeger , I have no objections to split the package, but it's not fully clear to me if you suggest to just split the extension for nemo or all (nautilus, nemo and caja).
The current package also contains the extension for caja, only dolphin has it's own sub-package nextcloud-client-dolphin-integration (but this contains more than one Python script).

Addressed the requested changes.
Added Solus customization details in the package description.

address requested changes: re-added some tlp.conf customisation

Hi @stalebrim , I still believe that the maintainers of TLP would not enable it by default if such issues are frequent.
They document that it may cause issues to help the few users facing problems, it doesn't mean that this is a frequent issue.
On the other hand Solus has no means to properly document that the package provided deviates from the TLP defaults.

My main concern is that those non-default settings are quite old and quite likely not valid anymore, at least on most platforms.
I assume that the TLP maintainers provide a good selection of default setting, working for vast majority of users. If any of those options frequently causes issues, it should be raised on upstream to get it changed.
One big issue with modifying the defaults provided by upstream is that this is not documented anywhere and for me as a user it was a bit surprising and most changes unwanted.
TLP provides good documentation, helping the user to fix potential issues like with WiFi if they get affected. But just because some (few) have been affected long back doesn't justify to change it for all.

removed unnecessarey change of patch file 001

updated summary

I've built tlp 1.5.0 locally and it works fine, but I have some concerns with the current patch for the tlp.conf file which changes a couple of default settings.
My impression is that those non-default values have been carried over from the old versions for quite a while and may not be adequate anymore. I checked the tlp package on Ubuntu and found that they deliver the plain default config, so what is the rationale to change them in Solus?
Some of them might be good for certain environments, but I doubt that they provide improvements or are needed in general. I'm currently testing with all default except the CPU governor for which I use custom values (defaults would be ok as well, but Solus setting is not optimal for me).

I rebuilt the nextcloud-client Solus package with the patch provided by @paolostivanin and it looks good (just did some basic tests). Hope it is getting soon into the stable-3.6 branch.

The issue with the nextcloud-client integration in Nautilus seems to be a GTK4 incompatibility caused by the Python package nautilus-terminal, for which there is already the issue #82 filed.

Hi @algent

If you do a make bump locally you will notice that package.yml will change to it defaults, and then just fix the release number to 1.

Hi @algent, the 2 space indentation was the default setting of the "Prettier" formatted in VScode. Changed it to 4 spaces now.

adjusted indentation to 4 spaces

Removed commendt line as requested.

removed comment as requested by @Girtablulu

removed obsolete info.md

1.7.3 was the first release based on Gtk 3, I'm using it on Solus since then without issues.

I installed latest calibre and found that it's even less usable for managing paper books than it was in the past, so no alternative for me.

It's long back that I tried calibre, was not my preference since it's focused on ebooks and I want to manage "real" books.
I will try latest calibre and see if it's a good alternative, but GCstar is used for all kind of collections, so other users may be interested in the non-book collection management.

Update: I still face this issue if I run specific applications like Brave browser or Signal before sending the laptop to sleep.
I still have no idea what the root cause of this bug is and what other troubleshooting could be done.

@joebonrichie Thanks a lot for your effort, will test as soon as the updated openjdk-11 package with D12494 is available.

Removed another obsolete install command

Removed some obsolete comment/test lines.

@JoshStrobl I added this D12464 as a parent revision for D12465, since the build of fritzing-parts uses the fritzing package.
Hope this is correct way to configure the dependency in Phabricator.
I also rebuilt the D12465 with make local to use the locally build package fritzing-0.9.9-10-1-x86_64.eopkg of this revision .

Addressed the changes requested by reviewer (removed unnecessary files).

Thanks @joebonrichie for your quick response.
I tried the updated version, but no difference. I can split or merge documents once, but after executing the first split the message icon on the top right turns red.

Corrections in changelog

Hi @JoshStrobl,
I had to change the pattern of the dolphin-integration to ensure that the VFS plugins /usr/lib64/qt5/plugins/nextcloudsync_vfs_suffix.so and /usr/lib64/qt5/plugins/nextcloudsync_vfs_xattr.so are packaged with the main nextcloud-client. I tried some other wildcard match to only include *dolphin*, but it didn't work and I though it's not really worth the effort for just 2 files.
Please suggest a suitable wildcard if you still think that the explicit statements aren't suitable.

removed obsolete command in install section (from testing)

In D11753#197295, @JoshStrobl wrote:

Refined the changelog. Copying it below so you can see how list items and the like should be done in the future:

@joebonrichie I can also confirm that this fixed the issue for me, thanks a lot for your effort to get this issue resolved!

Sorted builddeps alphabetically.

Sorted builddeps alphabetically.

Rebased for changes from R851:ec049f2e6e79: Update abireport for glibc

@DataDrake Not sure if there's anything still missing from my side or if it's just waiting in (possibly long) review queue?

I tested with a few different PDF documents, but for the tests above I used the RaspberryPi magazine which you can download for free: https://magpi.raspberrypi.org/issues/99
What still puzzles me is the randomness of the failures. Each crash seems a bit different and not exactly reproducible. Especially the conversion test with pdftocairo creates each run a slightly different crash at a different page. For Evince it's anyway harder to try an exact reproduction of the crash, but I have the impression that it's also a bit random when/where it happens.

Yes. tested on unstable.

Thanks @JoshStrobl for all your effort!
Unfortunately, it doesn't seem to fix the issues with Evince and pdf2cairo which I reported above. My laptop is fully updated on Solus Unstable and I also rebooted after updates to be sure.
After the latest updates I can still easily get Evince crashing like before and also with lib2cairo I get crashes as before:

@JoshStrobl For me the fix on libcairo doesn't fix the issue with Evince, it still crashes if e.g. I zoom a lot or scroll through the document pages.
Errors differ between crashes, e.g. double free or corruption (out) or corrupted size vs. prev_size (same as before libcairo patch).

Updated "common" to get "abi_used_symbols" included.

I still face issues with spontaneous log-offs, but quite rarely and not always immediately after wake-up from sleep.
Too rare to spend more time in debugging in my view - just hope that it fully disappears at some point :)

Interestingly the error varies a bit if I re-run the same debug procedure.
Not sure what could cause different crashes although the same PDF file is used (and the produced png deleted before the test).

I tested with unstable and get different error now, so unfortunately not fixed with the update.

Yesterday I had a crash after wake-up from sleep, in journalctl I can see an entry

@JoshStrobl thanks for clarification and your hint about possible patch dependency.

Looking at the dependency graphs, perl-package-deprecationmanager is a direct dependency for perl-datetime-format-strptime.

@joebonrichie thanks for the quick fix!

@JoshStrobl Sorry to say, but I'm getting a bit frustrated to wait that long for a quite simple update to get merged. Just wanted to help and contribute to the Solus project, but I get the feeling that my help is not much appreciated.
It also makes me worry to see packages in the repository without any updates since years, which could cause potential security risks (not in this case, but maybe for other packages).

Hi @jm-brennan , I'm simply running sudo journalctl -S -2h to see all detail. The start time is defined with the option -S -2h (since 2h ago), you can also specify an absolute date like -S "2021-03-16 20:00:00".

Some logs from one of todays' forced logoff's:

I have found a similar issue in Arch Linux forum, which seems to be solved by installing bbswitch which is available in Solus reop.
https://bbs.archlinux.org/viewtopic.php?id=244635

Hi @jm-brennan , I think I have the same issue since an update in early Janunary 2021.
Had some discussion about this problem in the Solus forum https://discuss.getsol.us/d/2616-laptop-doesn-t-properly-turn-on-after-suspend/, but no solution found.
It still seems to me that some applications like VS Code or Brave browser increase the probability that this happens, but without it also sometimes logs me out spontaneously shortly after wakeup from suspend.

Update to version 1.8.15, see https://marlam.de/msmtp/news/

Is there anything missing to get this merged?

Sorry, was not clear that single line is quite strict rule.