User Details
User Details
- User Since
- Nov 11 2021, 8:02 AM (90 w, 5 d)
Nov 13 2021
Nov 13 2021
Nov 12 2021
Nov 12 2021
Meztli requested review of D12286: Inclusion of Legendary Fixes T9305.
In D12286#207253, @algent wrote:should i add zlib as a builddep?
Not necessary , zlib is part of system.base component.
In D12286#207111, @algent wrote:Hi @Meztli
You don't need python-setuptools here because at the moment in Solus this package contains only python2 modules and is used for building python2 packages, and setuptools for python3 is included in python3 package and therefore no need to specify builddeps here for legendary.
As I recommended you in your forum post, last 7 lines shoud be:rundeps : - python-requests - python-wheel # to stop pip3 check complaining build : | %python3_setup install : | %python3_installpython-wheel is required optionally for setup/building. Maybe a better way is to patch setup.py file and remove this line.
In D12286#207089, @JoshStrobl wrote:You're missing a bunch of rundeps. I would suggest taking a look at their imports.