Landed in repo as of R3372:1b8bc0b77f2c9a356ca5b3d78d17cff7163974be
- Queries
- All Stories
- Search
- Advanced Search
- Transactions
- Transaction Logs
Advanced Search
May 7 2017
Correction. LGTM, going to land in repo now.
Landed in unstable as of R3371:343fcb3b8fd1ea368b493a21000fc2ff6e5a78a8
Correction. LGTM so gonna land it in now.
Landed in unstable as of R2060:30f9ae4de44f2ed801c61c2c2488118b8372f838
Landed in unstable as of R1772:c2d42401f5c109105238104888f6ca9bda1f788f
Correction, landing in the repo now.
Correction, landing in the repo now.
Landed in unstable as of R3368:da26955f2ca5cc6aa133621bb5617ef54b2cf413
Landed in unstable as of R3057:8f85d089df306ed7cedc35bce6ce18de7af85fd7
Landed in unstable as of R329:3b4d9e2be497db6c3c69f3bc4c7b9b38bee057e4
Landed in unstable as of R2726:61be7b5e6ba3a10a6d2625e1133605efc8dc5629
Landed as of R3369:4f244e7c3fa5c8b210458a0b6fb55997b7ea586e
Correction. Landing in repo now.
Correction, landing in new system now.
Correction, landing in new system now.
Correction, landing in new system now.
Correction, landing in new system now.
This Patch Submission will be closed as part of the migration to the Phabricator Differential application. It will need to be resubmitted using arcanist as described in Submitting The Package.
This Patch Submission will be closed as part of the migration to the Phabricator Differential application. It will need to be resubmitted using arcanist as described in Submitting The Package.
This Patch Submission will be closed as part of the migration to the Phabricator Differential application. It will need to be resubmitted using arcanist as described in Submitting The Package.
This Patch Submission will be closed as part of the migration to the Phabricator Differential application. It will need to be resubmitted using arcanist as described in Submitting The Package.
This Patch Submission will be closed as part of the migration to the Phabricator Differential application. It will need to be resubmitted using arcanist as described in Submitting The Package.
This Patch Submission will be closed as part of the migration to the Phabricator Differential application. It will need to be resubmitted using arcanist as described in Submitting The Package.
This Patch Submission will be closed as part of the migration to the Phabricator Differential application. It will need to be resubmitted using arcanist as described in Submitting The Package.
LGTM. However please submit it using the process below =)
This Patch Submission will be closed as part of the migration to the Phabricator Differential application. It will need to be resubmitted using arcanist as described in Submitting The Package.
This Patch Submission will be closed as part of the migration to the Phabricator Differential application. It will need to be resubmitted using arcanist as described in Submitting The Package.
This Patch Submission will be closed as part of the migration to the Phabricator Differential application. It will need to be resubmitted using arcanist as described in Submitting The Package.
This Patch Submission will be closed as part of the migration to the Phabricator Differential application. It will need to be resubmitted using arcanist as described in Submitting The Package.
This Patch Submission will be closed as part of the migration to
the Phabricator Differential application. It will need to be resubmitted
using arcanist as described in
Submitting The Package.
This Patch Submission will be closed as part of the migration to
the Phabricator Differential application. It will need to be resubmitted
using arcanist as described in
Submitting The Package.
This Patch Submission will be closed as part of the migration to
the Phabricator Differential application. It will need to be resubmitted
using arcanist as described in
Submitting The Package.
This Patch Submission will be closed as part of the migration to
the Phabricator Differential application. It will need to be resubmitted
using arcanist as described in
Submitting The Package.
This Patch Submission will be closed as part of the migration to
the Phabricator Differential application. It will need to be resubmitted
using arcanist as described in
Submitting The Package.
This Patch Submission will be closed as part of the migration to
the Phabricator Differential application. It will need to be resubmitted
using arcanist as described in
Submitting The Package.
This Patch Submission will be closed as part of the migration to
the Phabricator Differential application. It will need to be resubmitted
using arcanist as described in
Submitting The Package.
This Patch Submission will be closed as part of the migration to
the Phabricator Differential application. It will need to be resubmitted
using arcanist as described in
Submitting The Package.
This Patch Submission will be closed as part of the migration to
the Phabricator Differential application. It will need to be resubmitted
using arcanist as described in
Submitting The Package.
You shouldn't have empty steps. Move the python setup macro to build step and remove setup step entirely.
The setup macro should be in build, with the setup step removed.
This Patch Submission will be closed as part of the migration to
the Phabricator Differential application. It will need to be resubmitted
using arcanist as described in
Submitting The Package.
This Patch Submission will be closed as part of the migration to
the Phabricator Differential application. It will need to be resubmitted
using arcanist as described in
Submitting The Package.
This Patch Submission will be closed as part of the migration to
the Phabricator Differential application. It will need to be resubmitted
using arcanist as described in
Submitting The Package.
Apparently I had forgotten to move this to the appropriate column, sorry. Nonetheless, was updated via R1717:8c4f0d1d3c037d17331df3b06d7b9352340d92ef
Component should be changed to office, otherwise LGTM. In terms of MATE, I think T3560 is sufficient and we can follow-up on that after the merge.
This Patch Submission will be closed as part of the migration to the Phabricator Differential application. It will need to be resubmitted using arcanist as described in Submitting The Package.
This Patch Submission will be closed as part of the migration to the Phabricator Differential application. It will need to be resubmitted using arcanist as described in Submitting The Package.
This Patch Submission will be closed as part of the migration to the Phabricator Differential application. It will need to be resubmitted using arcanist as described in Submitting The Package.
Has since been updated to 0.36.3
LGTM, however please follow the below mentioned process. Thanks!
This Patch Submission will be closed as part of the migration to the Phabricator Differential application. It will need to be resubmitted using arcanist as described in Submitting The Package.
LGTM, however please follow the below mentioned process. Thanks!
Doesn't look correct at all. If you're going to paste the changelog, at least read it too. It states the Qt multimedia component is now needed. Nor was this tested, because had it been you would've noticed that there is in fact no GUI. ABI report validates this and the massive removal does too.
This Patch Submission will be closed as part of the migration to the Phabricator Differential application. It will need to be resubmitted using arcanist as described in Submitting The Package.
Has since been updated by @Justin, however he didn't re-enable optical media support (was changed to disable by default) so if you'd like to submit an updated patch, please follow the below mentioned process.
LGTM, however please follow the below mentioned process. Thanks!
Has since been updated to 0.40.1
LGTM. However please resubmit following the below mentioned process. Thanks!
This Patch Submission will be closed as part of the migration to the Phabricator Differential application. It will need to be resubmitted using arcanist as described in Submitting The Package.
This Patch Submission will be closed as part of the migration to the Phabricator Differential application. It will need to be resubmitted using arcanist as described in Submitting The Package.
This Patch Submission will be closed as part of the migration to the Phabricator Differential application. It will need to be resubmitted using arcanist as described in Submitting The Package.
Closing in favor of D30
This Patch Submission will be closed as part of the migration to the Phabricator Differential application. It will need to be resubmitted using arcanist as described in Submitting The Package.
This Patch Submission will be closed as part of the migration to the Phabricator Differential application. It will need to be resubmitted using arcanist as described in Submitting The Package.
This Patch Submission will be closed as part of the migration to the Phabricator Differential application. It will need to be resubmitted using arcanist as described in Submitting The Package.
This Patch Submission will be closed as part of the migration to the Phabricator Differential application. It will need to be resubmitted using arcanist as described in Submitting The Package.
This Patch Submission will be closed as part of the migration to the Phabricator Differential application. It will need to be resubmitted using arcanist as described in Submitting The Package.
This Patch Submission will be closed as part of the migration to the Phabricator Differential application. It will need to be resubmitted using arcanist as described in Submitting The Package.
Closing in favor of D27
This Patch Submission will be closed as part of the migration to the Phabricator Differential application. It will need to be resubmitted using arcanist as described in Submitting The Package.
Yes, LGTM, however will need to be submitted following the below mentioned process due to change in infra :)
LGTM. However, please follow the below mentioned information now that we've switched infra :)
Note: Need to potentially sideload the eopkg (the commit itself landed in the git repo), since the build server has issues with compiling itch for whatever reason. I'll poke @ikey about it and let Herald close this.
This Patch Submission will be closed as part of the migration to the Phabricator Differential application. It will need to be resubmitted using arcanist as described in Submitting The Package.
This Patch Submission will be closed as part of the migration to the Phabricator Differential application. It will need to be resubmitted using arcanist as described in Submitting The Package.
This Patch Submission will be closed as part of the migration to the Phabricator Differential application. It will need to be resubmitted using arcanist as described in Submitting The Package.
This Patch Submission will be closed as part of the migration to the Phabricator Differential application. It will need to be resubmitted using arcanist as described in Submitting The Package.
This Patch Submission will be closed as part of the migration to the Phabricator Differential application. It will need to be resubmitted using arcanist as described in Submitting The Package.
This Patch Submission will be closed as part of the migration to the Phabricator Differential application. It will need to be resubmitted using arcanist as described in Submitting The Package.
This Patch Submission will be closed as part of the migration to the Phabricator Differential application. It will need to be resubmitted using arcanist as described in Submitting The Package.
This Patch Submission will be closed as part of the migration to
the Phabricator Differential application. It will need to be resubmitted
using arcanist as described in
Submitting The Package.
Going to close this since you already moved it to Differential. Thanks :)
This Patch Submission will be closed as part of the migration to
the Phabricator Differential application. It will need to be resubmitted
using arcanist as described in
Submitting The Package.
May need to take a closer look at the licenses, but LGTM otherwise.
This Patch Submission will be closed as part of the migration to
the Phabricator Differential application. It will need to be resubmitted
using arcanist as described in
Submitting The Package.
This Patch Submission will be closed as part of the migration to
the Phabricator Differential application. It will need to be resubmitted
using arcanist as described in
Submitting The Package.
This Patch Submission will be closed as part of the migration to
the Phabricator Differential application. It will need to be resubmitted
using arcanist as described in
Submitting The Package.