Differential D7470 Diff 21302 package.yml

Changeset View

Standalone View

package.yml

This file was added.

				name : ibus-mozc
				version : 2.23.2815
				release : 1
				source :
				- git\|https://github.com/google/mozc : afb03ddfe72dde4cf2409863a3bfea160f7a66d8
				license : BSD-3-Clause
				component : desktop.core
				summary : Mozc engine for IBus.
				description: \|
				Japanese Input Method Editor for IBus.
				JoshStroblUnsubmitted Not Done Inline Actions We're not using any of the WTL bits, this can be removed. JoshStrobl: We're not using any of the WTL bits, this can be removed.
				builddeps :
				JoshStroblUnsubmitted Not Done Inline Actions This is only referenced in the installer, which we don't use. Not needed. JoshStrobl: This is only referenced in the installer, which we don't use. Not needed.
				- pkgconfig(Qt5Gui)
				JoshStroblUnsubmitted Not Done Inline Actions This is only referenced in the installer (which we don't use) and the unicode files don't mention a specific Unicode DFS license. JoshStrobl: This is only referenced in the installer (which we don't use) and the unicode files don't…
				- pkgconfig(gtk+-2.0)
				JoshStroblUnsubmitted Not Done Inline Actions I didn't see any reference to Unlicense in the codebase, where is this from? JoshStrobl: I didn't see any reference to Unlicense in the codebase, where is this from?
				- pkgconfig(ibus-1.0)
				setup : \|
				%patch -p1 < $pkgfiles/mozc.patch
				JoshStroblUnsubmitted Not Done Inline Actions Did you hand write your package.yml? We have a script to generate it: There's no other way you would've made this mistake, so seems like you need to correct all this and resubmit / update your diff: https://getsol.us/articles/packaging/packaging-practices/en/#generating-a-package-yml JoshStrobl: Did you hand write your package.yml? We have a script to generate it: There's no other way you…
				build : \|
				cd src
				GYP_DEFINES="ibus_mozc_path=/usr/lib64/ibus-mozc/ibus-engine-mozc server_dir=/usr/lib64/mozc" \
				python build_mozc.py gyp
				python build_mozc.py build -c Release unix/ibus/ibus.gyp:ibus_mozc server/server.gyp:mozc_server \
				JoshStroblUnsubmitted Not Done Inline Actions Eliminate the unnecessary new lines. JoshStrobl: Eliminate the unnecessary new lines.
				gui/gui.gyp:mozc_tool renderer/renderer.gyp:mozc_renderer
				install : \|
				pushd src/out_linux/Release
				install -Dm00755 ibus_mozc $installdir/usr/lib/ibus-mozc/ibus-engine-mozc
				for bin in mozc_renderer mozc_server mozc_tool; do
				JoshStroblUnsubmitted Not Done Inline Actions As mentioned in my previous review: All of your install commands should be combined like -Dm00644 or -Dm00755. Not to mention you should be using a loop over a list of files instead of line-by-line, file-by-file. This applies to all the images as well, so that needs to be corrected. So your installation of all these libs needs to be corrected. JoshStrobl: As mentioned in my previous review: > All of your install commands should be combined like…
				DataDrakeUnsubmitted Not Done Inline Actions No need for extra whitespace. DataDrake: No need for extra whitespace.
				install -Dm00755 $bin $installdir/usr/lib/mozc/$bin
				DataDrakeUnsubmitted Not Done Inline Actions You don't need to loop for a single file. DataDrake: You don't need to loop for a single file.
				done
				install -Dm00644 gen/unix/ibus/mozc.xml $installdir/usr/share/ibus/component/mozc.xml
				popd
				pushd src/data/images/unix
				mv ime_product_icon_opensource-32.png product_icon.png
				for icon in *.png; do
				DataDrakeUnsubmitted Not Done Inline Actions You don't need to loop for a single file. DataDrake: You don't need to loop for a single file.
				install -Dm00644 $icon $installdir/usr/share/ibus-mozc/${icon#ui-}
				JoshStroblUnsubmitted Not Done Inline Actions All of your install commands should be combined like `-Dm00644` or `-Dm00755`. Not to mention you should be using a loop over a list of files instead of line-by-line, file-by-file. This applies to all the images as well, so that needs to be corrected. JoshStrobl: All of your install commands should be combined like `-Dm00644` or `-Dm00755`. Not to mention…
				done
				JoshStroblUnsubmitted Not Done Inline Actions Not needed. JoshStrobl: Not needed.
				DataDrakeUnsubmitted Not Done Inline Actions No need for the extra whitespace between arguments. DataDrake: No need for the extra whitespace between arguments.