Differential D8534 Diff 20416 package.yml

Changeset View

Standalone View

package.yml

This file was added.

				name : broot
				version : 0.13.4
				release : 1
				source :
				- https://github.com/Canop/broot/archive/v0.13.4.tar.gz : fd9af3df87f61dbce01c262c71d07cd11221602da7662c321501772eb9a68fff
				license : MIT
				component : system.utils
				summary : A new way to see and navigate directory trees
				networking : yes
				builddeps : cargo
				DataDrakeUnsubmitted Done Inline Actions Should be a list format, even for one item. DataDrake: Should be a list format, even for one item.
				description: \|
				A new way to see and navigate directory trees using cd, tree, and fuzzy search.
				prep : \|
				DataDrakeUnsubmitted Done Inline Actions Did you mean "setup"? "prep" doesn't do anything. DataDrake: Did you mean "setup"? "prep" doesn't do anything.
				JoshStroblUnsubmitted Done Inline Actions description should go after summary, not after builddeps. JoshStrobl: description should go after summary, not after builddeps.
				mkdir -p build/x86_64-linux/

				build : \|
				cargo build --release --locked
				install : \|
				JoshStroblUnsubmitted Done Inline Actions According to https://github.com/Canop/broot/blob/master/build.rs they are also building shell completions and I see a man page dir in the project's root. We should ideally be installing what shell completions they do have: bash: `/usr/share/bash-completion/completions/` fish: `/usr/share/fish/completions/` zsh: `/usr/share/zsh/site-functions/` manpage location will be determined by the section they are expecting, probably `1` for general commands, so it should be installed to `/usr/share/man/man1/` and be sure it has `.1` appended to the end of the man page file name. JoshStrobl: According to https://github.com/Canop/broot/blob/master/build.rs they are also building shell…
				install -Dt "$installdir"/usr/bin target/release/broot
				DataDrakeUnsubmitted Done Inline Actions Should just be: install -Dm00755 target/release/broot $installdir/usr/bin/broot DataDrake: Should just be: ``` install -Dm00755 target/release/broot $installdir/usr/bin/broot ```
				JoshStroblUnsubmitted Done Inline Actions Seems like a fair bit of redundancy with how you're doing completions installation. You could more easily accomplish all of this using a pushd into the target out directory and loop a list of the completions or the directories and install from there. Otherwise it's a good start. JoshStrobl: Seems like a fair bit of redundancy with how you're doing completions installation. You could…
				install -Dm644 LICENSE "$installdir/usr/share/licenses/broot/LICENSE"
				DataDrakeUnsubmitted Done Inline Actions We don't ship license files unless upstream does it of their own volition. DataDrake: We don't ship license files unless upstream does it of their own volition.