Differential D1863 Diff 4599 files/avoid-invalid-free-when-ref_count.patch

Changeset View

Standalone View

				From 9aca3b6a087a396a81d7e26f4557eb97fecc1386 Mon Sep 17 00:00:00 2001
				From: =?UTF-8?q?Bj=C3=B6rn=20Esser?= <besser82@fedoraproject.org>
				Date: Wed, 13 Dec 2017 19:22:52 +0100
				Subject: [PATCH] json_object: Avoid invalid free (and thus a segfault) when
				ref_count gets < 0

				---
				json_object.c \| 5 +++++
				1 file changed, 5 insertions(+)

				diff --git a/json_object.c b/json_object.c
				index 042477a71b..7c7438d8ea 100644
				--- a/json_object.c
				+++ b/json_object.c
				@@ -182,6 +182,11 @@ int json_object_put(struct json_object *jso)
				{
				if(!jso) return 0;

				+ /* Avoid invalid free and crash explicitly instead of (silently)
				+ * segfaulting.
				+ */
				+ assert(jso->_ref_count > 0);
				+
				#if defined(HAVE_ATOMIC_BUILTINS) && defined(ENABLE_THREADING)
				/* Note: this only allow the refcount to remain correct
				* when multiple threads are adjusting it. It is still an error