I've built tlp 1.5.0 locally and it works fine, but I have some concerns with the current patch for the tlp.conf file which changes a couple of default settings.
My impression is that those non-default values have been carried over from the old versions for quite a while and may not be adequate anymore. I checked the tlp package on Ubuntu and found that they deliver the plain default config, so what is the rationale to change them in Solus?
Some of them might be good for certain environments, but I doubt that they provide improvements or are needed in general. I'm currently testing with all default except the CPU governor for which I use custom values (defaults would be ok as well, but Solus setting is not optimal for me).

My proposal is to either remove the patch from the package or document why values have been changed.
A lot of the patches are anyway just setting the default value, so should be removed to avoid confusion.

I disagree with the tweaks not being adequate anymore. The most probable reason for Josh disabling WIFI/audio power saving and USB autosuspend is that depending on the hardware they caused poor wireless reception, audio cut-offs etc. My own experience with USB autosuspend is that regardless of having a blacklist, TLP still applied autosuspend to my HID devices. This meant my USB mouse getting lost after a couple of seconds not in use.

Since part of Solus' philosophy is providing sane out-of-the-box experiences and defaults, some which may run counter to their upstream counterparts, I perceive ensuring the least amount of hardware issues with the current provided defaults is in line with that vision. The only exception is the performance governor on AC, I'd propose changing that to whatever governor Solus normally defaults to.

My main concern is that those non-default settings are quite old and quite likely not valid anymore, at least on most platforms.
I assume that the TLP maintainers provide a good selection of default setting, working for vast majority of users. If any of those options frequently causes issues, it should be raised on upstream to get it changed.
One big issue with modifying the defaults provided by upstream is that this is not documented anywhere and for me as a user it was a bit surprising and most changes unwanted.
TLP provides good documentation, helping the user to fix potential issues like with WiFi if they get affected. But just because some (few) have been affected long back doesn't justify to change it for all.

As I installed the TLP package originally, I was expecting to get the default settings as per TLP documentation and a bit surprised that some power saving options had been disabled in Solus package.

I appreciate that Solus tries to provide a good out-of-the-box experience (which I like a lot), but in this case I think that the old tweaks should at least be carefully reviewed.

If I correctly understand the TLP documentation, the CPU governor should be schedutil for newer kernels/distributions anyway (if supported!), so maybe this could be generally addressed by the kernel config instead of TLP tweak?

From the TLP documentation:

Power saving mode can cause an unstable Wi-Fi link.
Power saving mode may cause slight clicks or other disturbances in sound output
Symptom: some USB devices do not work reliable when TLP activates USB autosuspend mode. Solution: lookup the corresponding USB device ID with lsusb, add it to USB_DENYLIST and reconnect the device.

I think it still makes sense to have these features disabled by default. Since TLP gets enabled automatically upon the installation of the package, I think it's a reasonable expectation that it works out of the box without having to troubleshoot a wrecked wireless connection or having to add various USB devices to exception lists.

If I correctly understand the TLP documentation, the CPU governor should be schedutil for newer kernels/distributions anyway (if supported!), so maybe this could be generally addressed by the kernel config instead of TLP tweak?

Looking at it TLP defaults to none and I agree it would be the best solution to have TLP not touch the governor at all.

Hi @stalebrim , I still believe that the maintainers of TLP would not enable it by default if such issues are frequent.
They document that it may cause issues to help the few users facing problems, it doesn't mean that this is a frequent issue.
On the other hand Solus has no means to properly document that the package provided deviates from the TLP defaults.

TLP is not part of the Solus base system and only installed on user request, so I would assume that the user checks the TLP documentation for it's usage and doesn't expect to get a modified TLP out-of-the-box.
I'm running Solus on a Lenovo X220 and have no issues with the WiFi or USB using the original TLP defaults now, but I only came to know that some of this setting had been disabled (causing higher battery consumption) as I was looking into the package upgrade.

Thank you very much! :)

Stop charge threshold now works in my Asus.