Page MenuHomeSolus
Create Task
Maniphest T9688

Add perl-datetime-format-strptime missing runtime dependencies
Closed, InvalidPublic
Actions

Description

I found that the perl library perl-datetime-format-strptime is missing some runtime dependencies.

  • perl-class-singleton
  • perl-package-deprecationmanager
  • perl-sub-install

I tested the library with a small sample script:

use DateTime::Format::Strptime;

my $strp = DateTime::Format::Strptime->new(
    pattern   => '%T',
    locale    => 'en_AU',
    time_zone => 'Australia/Melbourne',
);

my $dt = $strp->parse_datetime('23:16:42');

$strp->format_datetime($dt);

I can submit a patch, but was not sure about the usual process for such issues.
Should a task be opened first or can I also directly submit a patch and explain the reason within the patch itself?

Related Objects

Event Timeline

palto42 created this task.Apr 25 2021, 8:13 AM
Herald added a project: Lacks Project. · View Herald TranscriptApr 25 2021, 8:13 AM
palto42 added a comment.EditedApr 25 2021, 8:17 AM

Looking at the dependency graphs, perl-package-deprecationmanager is a direct dependency for perl-datetime-format-strptime.

The perl-class-singleton should be a dependency of perl-datetime-timezone. In my view the dependency on perl-datetime can be removed here because it's actually a reverse-dependency. Furthermore, there is a typo in the package.yml, it should be rundeps rather than runddeps.

The package perl-sub-install is a dependency of perl-package-deprecationmanager

JoshStrobl closed this task as Invalid.Apr 25 2021, 9:37 AM
JoshStrobl added a subscriber: JoshStrobl.

Should a task be opened first

Given it's an existing package, no. You're welcome to just submit patches. Just be sure to use the stack functionality to add child / parent revisions, or alternatively use language Depends on D#, replacing # with the patch number to indicate that "this" patch requires another one to be landed first.

palto42 added a comment.Apr 25 2021, 11:55 AM

@JoshStrobl thanks for clarification and your hint about possible patch dependency.

From my dependency research I found that three packages are missing a dependency, but there is no strict child/parent dependency on updating the packages in any order as far as I can see.

palto42 mentioned this in D10917: Add rundep for perl-sub-install.Apr 25 2021, 12:19 PM
palto42 mentioned this in D10918: Add rundep for perl-class-singleton, fix typo.Apr 25 2021, 12:24 PM
palto42 mentioned this in D10919: Add rundeps for perl-package-deprecationmanager.
DataDrake mentioned this in R2339:241ce39ebeca: Add rundep for perl-class-singleton, fix typo.May 14 2021, 4:34 PM
DataDrake mentioned this in R2387:c746fb8f0946: Add rundep for perl-sub-install.
DataDrake mentioned this in R2337:8ce46baba466: Add rundeps for perl-package-deprecationmanager.May 14 2021, 6:09 PM
Copyright © 2015-2021 Solus Project. The Solus logo is Copyright © 2016-2021 Solus Project. All Rights Reserved.