Page MenuHomeSolus
Create Task
Maniphest T942

fritzing-parts
Closed, ResolvedPublic
Actions

Description

0001-Initial-working-fritzing-parts.patch693 KBDownload

Related Objects
Search...

StatusSubtypeAssignedTask
 ResolvedSFaulkenT930 Fritzing Parts
 ResolvedJoshStroblT942 fritzing-parts
 ResolvedJoshStroblT943 Fritzing Update

Event Timeline

SFaulken created this task.Oct 2 2016, 11:53 PM
SFaulken added a parent task: T930: Fritzing Parts.
SFaulken added a subtask: T943: Fritzing Update.
JoshStrobl moved this task from Backlog to Awaiting Fixes on the Patch Submission board.Oct 6 2016, 2:09 PM
JoshStrobl added a subscriber: JoshStrobl.

Why aren't you just copy / pasting the content into $installdir/usr/share/fritzing/parts then doing a single recursive chmod? Would clean it up a lot.

SFaulken added a comment.Oct 6 2016, 3:05 PM

0001-Initial-working-fritzing-parts.patch981 KBDownload

JoshStrobl added a comment.Oct 8 2016, 7:55 AM

Please start checking if you have commented out lines before submitting patches. Those need to be removed.

JoshStrobl mentioned this in T943: Fritzing Update.Oct 8 2016, 8:06 AM
SFaulken added a comment.Oct 8 2016, 4:40 PM

0001-Initial-working-fritzing-parts.patch979 KBDownload

JoshStrobl claimed this task.Oct 8 2016, 5:45 PM
JoshStrobl triaged this task as Normal priority.
JoshStrobl moved this task from Awaiting Fixes to Ready For Merge on the Patch Submission board.

LGTM.

JoshStrobl closed this task as Resolved.Oct 8 2016, 5:51 PM

Landed in unstable as of https://git.solus-project.com/packages/fritzing-parts/commit/?id=188d8636504392e7a8225df91653f72cf8201a20

Thanks!

JoshStrobl closed subtask T943: Fritzing Update as Resolved.Oct 8 2016, 6:13 PM
Copyright © 2015-2021 Solus Project. The Solus logo is Copyright © 2016-2021 Solus Project. All Rights Reserved.