Page MenuHomeSolus

OmegaT
Closed, ResolvedPublic

Description

See: https://dev.solus-project.com/T900

Related Objects

StatusAssignedTask
ResolvedSFaulken
ResolvedJoshStrobl

Event Timeline

SFaulken created this task.Sep 30 2016, 8:51 PM
JoshStrobl added a subscriber: JoshStrobl.
  1. mkdir calls need to be replaced with install.
  2. Most of the mkdir calls aren't even necessary with the appropriate install flags in the first place.
  3. component should be office.

Why would I put a translation framework software package in office? It doesn't actually do the translations

Looks pretty clear to me why it should be on office: http://www.omegat.org/images/screenshot1.jpg

It's used for translations, whether or not it actually does the translations. Regardless, doesn't belong in desktop.

fixed

Not exactly. Use of install for applications and bin dirs aren't necessary. Please read up on install.

If I remove the install lines for /usr/bin and /usr/share/applications, or don't do a mkdir for them, my result is:

install: target '/var/ypkg-root/root/OmegaT/install/usr/bin/' is not a directory: No such file or directory

I've read the install manpage about a thousand times, and been googling, and I still have no idea what it is you're getting at.

Right, you need to add the filename after the /usr/bin/ bit, same goes with the .desktop file. There are plenty of examples in the repo.

JoshStrobl triaged this task as Normal priority.
JoshStrobl moved this task from Awaiting Fixes to Ready For Merge on the Patch Submission board.

LGTM.

I swear, this fucking package is going to kill me.

Any chance somebody else can grab my package.yml and build this locally, and see if their git format-patch results in something that is importable?

I have no idea what's going on here, but I've tried everything I can think of, and everytime I do a git am, I end up with a non-appliable 0001-disable_win_mac.patch

This should get you sorted:

ant is a bear to work with, even if you know it!

@DataDrake Your patch needs to be applied on top of the existing git repo and rel needs to be revved to 2.

Here ya go.

Thanks for your hard work. This is really one of my most wanted packages.

JoshStrobl added a comment.EditedOct 11 2016, 4:49 PM

Yea...package still needs to be revisioned to rel 2.

DataDrake closed this task as Resolved.Oct 23 2016, 5:06 AM

Landed in unstable after a few tweaks:

https://git.solus-project.com/packages/omegat/commit/?id=743c9e6fd4ed4186fdfa4ac2eb425d13d52776bf

Note that I made the package name lowercase to match the Git repo.