Page MenuHomeSolus

Update boost to 1.72.0
Closed, ResolvedPublic

Description

Update June 20th, ready to land ! Thanks for your patches submission, it's really appreciated ! 😄

DonePackageComment
yeslibboostD8527
yeslibcmis
yeslibixion
yesliborcus
yeslucenexx
yeslibkolabxml
yesncmpcpp
yeslibtorrent-rasterbarswitch to autotools
yesopenimageio
yesutsushi
yescgalupdated to 5.0.2
yesnatron
yesvcmibuild from git – deprecate vmci-devel
yesogre
yesluminance-hdr
yespython-cheetahD8971 (not boost, required by mongodb)
yeswiredtigerD8974 (not boost, required by mongodb)
yesmongodbD8975
yespulseeffects
yespoedit
yes0ad
yesgource
yesfreeorion
yeseasystroke
yesgnucash
yesmupen64plus
yesinnoextractD8680
yesthunderbolt-software-user-space
yeseiskaltdcppD8653
yestomahawk
yesyosys
yessynfig
yespulseview
yeshugin
yesopenmw
yessupercollider
yeswesnoth
yespinguspatched
yessupertux
yesastroid
yesfifengine
yespeercoinupdated to 0.9.0
yesbitcoin
yesradiotray-ng
yesqbittorrent
yesrstudioD9012
yesguitarix
yesopenscadpatched
yesledgerok with python 2.7
yeswidelands
yesmkvtoolnix
yeslibreofficeupdated to 6.4.4.2
yeskrita
yesblender
yesgraph-toolD8528 (then updated to 2.32)
yeskicad

Event Timeline

Girtablulu updated the task description. (Show Details)Mar 22 2020, 9:01 AM

Regarding innoextract - I was able to rebuild it against 1.72 with -DBoost_NO_BOOST_CMAKE=ON flag. According to relevant issues (innoextract, CMake), it's a problem with changes in Boost configurations and standard FindBoost script in CMake. The provided flag workarounds the issue by ignoring the problematic config file from Boost (see documentation).

DataDrake triaged this task as Normal priority.Mar 23 2020, 1:01 PM
DataDrake moved this task from Backlog to Update Requested on the Software board.
kyrios123 updated the task description. (Show Details)Mar 30 2020, 8:25 PM
kyrios123 updated the task description. (Show Details)Mar 31 2020, 6:37 PM
algent added a subscriber: algent.Apr 3 2020, 7:50 PM

Builded innoextract using git b47f46102bccf1d813ca159230029b0cd820ceff

source     :
     - git|https://github.com/dscharrer/innoextract : b47f46102bccf1d813ca159230029b0cd820ceff

CMake: Remove library link checks
This was needed with older CMake versions to work around CMake searching
under lib with -m32 instead of under lib32 for platforms where lib
contains 64-bit binaries. This has since been fixed in CMake and users
of older CMake versions can add the lib32 directories to
CMAKE_LIBRARY_PATH to work around the issue on their end.
With newer CMake and Boost versions these checks fail because the
boost-config.cmake files shipped with Boost use imported targets instead
of library paths and try_compile does not add these imported targets to
the generated project.
See: https://gitlab.kitware.com/cmake/cmake/issues/11260

ermo updated the task description. (Show Details)Apr 10 2020, 3:30 PM

Build successfully eiskaltdcpp with this patch. fix-build-with-pango-1.44.patch

diff --git a/cmake/FindGTK3.cmake b/cmake/FindGTK3.cmake
index 9017c0703..a933c6cfa 100644
--- a/cmake/FindGTK3.cmake
+++ b/cmake/FindGTK3.cmake
@@ -128,10 +128,11 @@ function(_GTK3_FIND_INCLUDE_DIR _var _hdr)
         gtkmm-2.4
         libglade-2.0
         libglademm-2.4
+        harfbuzz
         pango-1.0
         pangomm-1.4
         sigc++-2.2
-    gtk-unix-print-2.0
+        gtk-unix-print-2.0
     )
 
     set(_suffixes)
@@ -425,6 +426,8 @@ foreach(_GTK3_component ${GTK3_FIND_COMPONENTS})
         _GTK3_FIND_INCLUDE_DIR(GTK3_PANGO_INCLUDE_DIR pango/pango.h)
         _GTK3_FIND_LIBRARY    (GTK3_PANGO_LIBRARY pango false true)
 
+        _GTK3_FIND_INCLUDE_DIR(GTK3_HARFBUZZ_INCLUDE_DIR hb.h)
+
         _GTK3_FIND_INCLUDE_DIR(GTK3_ATK_INCLUDE_DIR atk/atk.h)
         _GTK3_FIND_LIBRARY    (GTK3_ATK_LIBRARY atk false true)
kyrios123 added a comment.EditedApr 11 2020, 4:43 PM

@algent and others you can submit the patches directly just add Depends on D8527 in the summary.

mygui can be removed from the rebuild list, because as of R2125:9c87bcdd1cf8d8692f89a4089955f3317a5ffed8 it no longer depends on Boost.

So only two left here rstudio and vcmi.

VCMI is tricky one. Its master branch should build against latest Boost, but its last release differs too much from the master, so patches for Boost compat don't apply cleanly. A lot of code that breaks with latest Boost was completely removed from master years ago, so we have to patch it ourselves if we want to continue with release sources.
And mainteinance of project isn't very good - apparently they attempted to issue 0.100 release last year, but for some reason it stuck and there is no sign of ETA for it.
Moving to master would be the easiest way to get compat with new Boost, patching 0.99 codebase require some knowledge about VCMI engine. Or maybe someone else has already patched this and we could incorporate the changes.

akrenz added a subscriber: akrenz.Jun 6 2020, 11:59 PM

I have submitted a patch for rstudio to build against boost 1.72. See D9012

akrenz added a comment.Jun 8 2020, 5:45 AM

Maybe include latest Master of VCMI with a release version like 2006 (yymm)? Or deprecate it and wait for a new release. I would go for the first version. VCMI is not badly maintained...they just have bad release management (none at all?)

kyrios123 updated the task description. (Show Details)Jun 16 2020, 4:19 PM
kyrios123 updated the task description. (Show Details)Jun 16 2020, 4:25 PM
kyrios123 updated the task description. (Show Details)Jun 16 2020, 4:30 PM
kyrios123 updated the task description. (Show Details)Jun 19 2020, 9:32 PM
kyrios123 updated the task description. (Show Details)Jun 20 2020, 7:07 AM
JoshStrobl closed this task as Resolved.Tue, Jul 14, 8:50 AM
JoshStrobl claimed this task.

Marking as resolved since @kyrios123 has since updated libboost to 1.72.0