Page MenuHomeSolus
Create Task
Maniphest T8184

Meta: Update Task SDL2.0.10
Closed, ResolvedPublic
Actions

Description

This is a task regarding SDL2 update, to check if everything works and can be build

Local Building

  • SDL2
  • rev deps
  • sdl2-32bit
  • sdl2-gfx
  • sdl2-image
  • sdl2-mixer
  • sdl2-net
  • sdl2-ttf
  • 0ad
  • astromenace
  • audacious-plugins
  • blender
  • blobby2
  • bzflag
  • chocolate-doom
  • dhewm3
  • dolphin-emu
  • doomsday-engine
  • dreamchess
  • endless-sky
  • etlegacy
  • faudio
  • ffmpeg
  • fifechan
  • fifengine
  • flare-engine
  • freeorion
  • fs-uae-dev
  • gegl
  • gource
  • guvcview
  • gweled
  • gzdoom
  • hatari
  • hedgewars
  • iortcw
  • libmikmod
  • libTAS
  • love
  • lugaru
  • m64py
  • mame
  • megaglest
  • megazeux
  • mgba
  • milkytracker
  • mlt
  • movit
  • mrboom
  • mupen64plus
  • naev
  • neverball
  • ogre
  • ois
  • openal-soft
  • openclonk
  • openmw
  • openra
  • openrct2
  • openspades
  • openscenegraph
  • pacman
  • pcsx2
  • pioneer
  • ppsspp
  • projectm
  • qdriverstation
  • qemu
  • qrencode
  • quakespasm
  • razer-drivers
  • redeclipse
  • retroarch
  • scrcpy
  • scummvm
  • snes9x-gtk
  • solarus
  • solarus-quest-editor
  • starfighter
  • stella
  • stone-soup
  • supertux
  • taisei
  • teeworlds
  • The-Powder-Toy
  • vcmi
  • VisualBoyAdvance-M
  • warzone2100
  • wesnoth
  • widelands
  • wine
  • wxPython
  • xonotic
  • yquake2
  • freedink
diff --git a/src/input.cpp b/src/input.cpp
index b5ae21e..9c4186a 100644
--- a/src/input.cpp
+++ b/src/input.cpp
@@ -91,7 +91,8 @@ void input_init(void)
 
   // TODO: don't attempt to simulate mouse events from touch events -
   // fake mouse events often are de-centered
-  SDL_SetHint(SDL_HINT_ANDROID_SEPARATE_MOUSE_AND_TOUCH, "0");
+  SDL_SetHint(SDL_HINT_MOUSE_TOUCH_EVENTS, "1");
+  SDL_SetHint(SDL_HINT_TOUCH_MOUSE_EVENTS, "1");
 
   /* Touch devices */
   {
  • usdx
  • klystrack
  • manaplus
  • add new Builddeps pkgconfig(krb5) pkgconfig(libnghttp2) pkgconfig(libssh2)
  • opentoonz
  • shotcut
  • Update to latest stable required
  • rundeps
  • python-sdl2
  • steam
  • wine
  • fails to build
  • remove from repo ?
  • antimicro - Source repo seems to be abandoned and causes issues on other distros as well
  • qmc2 No rule to make target 'QtWebKit/QWebView', needed by 'ui_htmleditor.h'. Stop.
    • with QT5.13 update I had to update Qt5-Webkit as well, since then it does not build and I don't see anything upstream working on support for this

Details

Commits
D6904 / R2866:e1f242c8ab59: Update SDL2 to 2.0.10

Event Timeline

Girtablulu created this task.Jul 26 2019, 12:35 PM
Girtablulu updated the task description. (Show Details)
Girtablulu triaged this task as Normal priority.Jul 26 2019, 2:54 PM
Girtablulu added a project: Platform Integration.
Girtablulu moved this task from Backlog to Improvement on the Software board.
Girtablulu updated the task description. (Show Details)
Girtablulu updated the task description. (Show Details)
Girtablulu updated the task description. (Show Details)Jul 26 2019, 3:59 PM
Girtablulu claimed this task.Jul 26 2019, 8:16 PM
Girtablulu updated the task description. (Show Details)
Girtablulu updated the task description. (Show Details)Jul 26 2019, 8:48 PM
Girtablulu updated the task description. (Show Details)Jul 26 2019, 9:37 PM
Girtablulu updated the task description. (Show Details)Jul 26 2019, 10:20 PM
Girtablulu updated the task description. (Show Details)Jul 27 2019, 10:36 AM
Girtablulu updated the task description. (Show Details)Jul 27 2019, 11:47 AM
Girtablulu updated the task description. (Show Details)Jul 27 2019, 11:54 AM
kyrios123 added a subscriber: kyrios123.Jul 27 2019, 1:43 PM

FYI - wxPython2 is not used by anything anymore and can be deprecated -> no need to rebuild it.

Girtablulu added a comment.Jul 27 2019, 2:05 PM

just hit it ;D

Girtablulu updated the task description. (Show Details)Jul 27 2019, 2:07 PM
Girtablulu updated the task description. (Show Details)Jul 27 2019, 2:15 PM
Girtablulu updated the task description. (Show Details)Jul 27 2019, 3:34 PM
Girtablulu updated the task description. (Show Details)Jul 27 2019, 3:48 PM
Girtablulu updated the task description. (Show Details)Jul 27 2019, 4:04 PM
Girtablulu updated the task description. (Show Details)
Girtablulu updated the task description. (Show Details)Jul 27 2019, 5:55 PM
Girtablulu updated the task description. (Show Details)Jul 27 2019, 6:01 PM
Girtablulu updated the task description. (Show Details)Jul 27 2019, 6:07 PM
aleksvor added a subscriber: aleksvor.Jul 28 2019, 6:11 AM

Great work!
Btw, cheers for patching freedink :) I was going to look into patching it after you reported an error, but I'm away from my main PC this weekend.
About error with OpenToonz - this looks like a regression in CMake's Ninja generator? Can you try rebuilding it with GNU makefiles? Or I can try it on the next week.

DataDrake added a subscriber: DataDrake.Jul 28 2019, 12:34 PM

Technically I was the one that patched it :p just trying to keep this moving since Girt got so much done already.

Girtablulu added a comment.Jul 28 2019, 1:17 PM

@aleksvor even with switching back it fails sadly, gonna keep looking into it

@DataDrake no one recognizes your work :P

Girtablulu updated the task description. (Show Details)Jul 28 2019, 2:12 PM
Girtablulu updated the task description. (Show Details)Jul 28 2019, 4:40 PM
joebonrichie added a subscriber: joebonrichie.EditedJul 28 2019, 6:31 PM

@Girtablulu For manaplus chroot in and look at the config.log. There was a similar error i encountered when updating R with missing curl, but it was just additional missing pkgconfigs.

edit: More specifically it was pkgconfig(libssh2), pkgconfig(libnghttp2), pkgconfig(krb5), pkgconfig(com_err)

Girtablulu updated the task description. (Show Details)Jul 28 2019, 7:21 PM
Girtablulu updated the task description. (Show Details)Aug 2 2019, 10:47 PM
aleksvor added a comment.Aug 3 2019, 10:42 AM

@Girtablulu Regarding OpenToonz again - I finally rebuilt it locally and can confirm that it builds against SDL 2.0.10 (locally updated) and works with it. However, I had to make several tweaks to package.yml:

  1. Switch build system from Ninja to GNU Make - because Ninja doesn't work with the build script that CMake produces (same error as you mentioned).
  2. Switch compiler from GCC to Clang - for some reason GCC segfaults while building OT, but Clang is able to build the whole thing. I didn't investigate this problem in detail as of now.
  3. Backport upstream patch that fixes incompatibility with Qt 5.13 (nothing serious, just one missing header).
Girtablulu added a comment.EditedAug 3 2019, 11:23 AM

Can you upload the package.yml? And thx for checking :)

aleksvor added a comment.Aug 3 2019, 12:00 PM

package.yml1 KBDownload

0001-Fix-Qt-5.13-build-error-2665.patch619 BDownload

Here you are :) These patches should work.

Girtablulu updated the task description. (Show Details)Aug 4 2019, 6:23 PM
Girtablulu updated the task description. (Show Details)Aug 6 2019, 6:39 PM
joebonrichie added a comment.Aug 9 2019, 10:51 PM

Deprecating shotcut!? Know how many people use that. Pretty sure mlt and shotcut just need updating.

joebonrichie added a comment.Aug 9 2019, 11:00 PM

Updated mlt to 6.16.0 and shotcut to 19.08beta, it builds and seems to work. Haven't tested the non-beta version yet but it could be updated regardless.

Girtablulu added a comment.Aug 10 2019, 6:37 AM

It still fails for me can you push your stuff?

joebonrichie updated the task description. (Show Details)Aug 11 2019, 3:31 PM
Copyright © 2015-2019 Solus Project. The Solus logo is Copyright © 2016-2019 Solus Project. All Rights Reserved.