Page MenuHomeSolus

zstd
Closed, ResolvedPublic

Description

URL: http://cyan4973.github.io/zstd/

Zstandard is a real-time compression algorithm, providing high compression ratios. It offers a very wide range of compression / speed trade-off, while being backed by a very fast decoder (see benchmarks below). It also offers a special mode for small data, called dictionary compression, and can create dictionaries from any sample set. Zstandard library is provided as open source software using a BSD license.

From the same developer of the LZ4 compression format and tool. This patch is for the Zstandard shared libraries and compression tool.

Event Timeline

mfossen created this task.Aug 7 2016, 5:34 AM
JoshStrobl triaged this task as Normal priority.Aug 11 2016, 8:39 AM
JoshStrobl added a subscriber: JoshStrobl.

Fixes needed:

  1. Please fix the whitespacing before the builddeps.
  2. .so.* files should be in the base package, not -devel, unless there is an issue that warrants libsplit : no.
  3. There is no mention of GPL-2.0 as the license that I can find, whereas it is indeed explicitly indicating BSD-2-Clause here. Unless I'm incorrect, please change license field to be license : BSD-2-Clause.

Sorry for my late response on this, thanks for taking a look at my patch.

  1. Whitespace should be fixed.
  1. I removed the "Patterns" section so that should fix the issue.
  1. I think the library is under the BSD license, but the command line tool is under the GPL. These files have the GPL text: here and here

If I'm still mistaken I'll fix it and resubmit.

Looks good to me. Will be added once builder is back up.

JoshStrobl closed this task as Resolved.Aug 23 2016, 9:57 AM

Landed with your patch and just some minor whitespacing tweaks with: https://git.solus-project.com/packages/zstd/commit/?id=5ac350ea951ea9cfd4f7efc4d6e588cdb47d12e8

Thanks again!