Page MenuHomeSolus
Create Task
Maniphest T7731

Maybe firefox.desktop and thunderbird.desktop consistent
Closed, ResolvedPublic
Actions

Description

firefox.desktop and thunderbird.desktop are not written in the same style.

Compare https://dev.getsol.us/source/firefox/browse/master/files/firefox.desktop$3 and https://dev.getsol.us/source/thunderbird/browse/master/files/thunderbird.desktop$3

Name=Firefox
GenericName=Web Browser
Comment=Browse the Web

Name=Mozilla Thunderbird Mail/News
Comment=Read/Write Mail/News with Mozilla Thunderbird
GenericName=Mail Client

I like the very short Firefox strings and dislike the very long Thunderbird strings.

I suggest changing thunderbird.desktop to something like:

Name=Thunderbird
Comment=Read and write Mail/News
GenericName=Mail Client

Maybe:
GenericName=Mail/News Client

Maybe fix the order of lines starting with the following so they come in the same order in both files:
Name
Comment
GenericName

Revisions and Commits

R3035 thunderbird
D5829R3035:8dba61386dca Update thunderbird to 60.6.0

Related Objects

Event Timeline

scootergrisen created this task.Mar 21 2019, 10:37 PM
Herald added a project: Lacks Project. · View Herald TranscriptMar 21 2019, 10:37 PM
Girtablulu assigned this task to kyrios123.Mar 21 2019, 10:38 PM
Girtablulu edited projects, added Software; removed Lacks Project.
Girtablulu added subscribers: kyrios123, Girtablulu.

@kyrios123 as the Maintainer, what's your opinion on this?

scootergrisen added a comment.Mar 21 2019, 10:52 PM

Maybe the .desktop files should just be updated from where ever they come from.
Like each time the package/Firefox/Thunderbird is updated the .desktop files should also be updated to get the latest changes.

Jacalz added a subscriber: Jacalz.Mar 22 2019, 8:11 AM

I think this would be a good idea for better consistency ?

kyrios123 changed the task status from Open to In Progress.Mar 22 2019, 10:32 AM
kyrios123 added a project: Needing Desktop Actions.
kyrios123 added subscribers: • sunnyflunk, DataDrake, JoshStrobl.

I'll fix this and I'll also add Desktop Actions for Thunderbird so @JoshStrobl will be happy :)

But first I need some one perhaps @DataDrake or @sunnyflunk if he's around to run the lang scripts for firefox 66.0 and for thunderbird 60.6.0 because I won't rebuild these monsters just for the .desktop file while new versions have been released.

Herald reassigned this task from kyrios123 to JoshStrobl. · View Herald TranscriptMar 22 2019, 10:32 AM

Assigning JoshStrobl to investigate and triage. Referencing T7289.

  • Herald, our Phabricator bot
kyrios123 claimed this task.Mar 22 2019, 10:33 AM

Tsst tsssttt @Herald

kyrios123 added a revision: D5829: Update thunderbird to 60.6.0.Mar 23 2019, 5:28 PM
kyrios123 closed this task as Resolved by committing R3035:8dba61386dca: Update thunderbird to 60.6.0.Mar 23 2019, 5:52 PM
kyrios123 added a commit: R3035:8dba61386dca: Update thunderbird to 60.6.0.
scootergrisen added a comment.Mar 23 2019, 5:56 PM

Now the source/english Name, Comment, and GenericName looks fine to me but the translation are the translation of the old strings.
So what do i do if i want to fix the translations to match the source?

Copyright © 2015-2021 Solus Project. The Solus logo is Copyright © 2016-2021 Solus Project. All Rights Reserved.