Page MenuHomeSolus
Create Task
Maniphest T7730

Enable GitHub Pull Request extension to use proposed API in VSCode
Closed, ResolvedPublic
Actions

Description

Josh,

Will you enable the proposed API for GitHub.vscode-pull-request-github?

Thanks

Details

Commits
R3148:c1c8950b899c: Add additional proposed extension APIs.

Event Timeline

• tristan957 added a comment.Mar 21 2019, 6:27 PM

If you will accept a patch, I can also provide one

Girtablulu assigned this task to JoshStrobl.Mar 22 2019, 9:19 AM
Girtablulu added subscribers: JoshStrobl, Girtablulu.

Assign to @JoshStrobl as the maintainer for opinion

• tristan957 added a comment.Mar 22 2019, 1:48 PM

I did realize that you can just enable it from the command line. Although I know some extensions get defaulted in the product.json file. Not a big deal if this task is closed or fixed.

• tristan957 added a comment.Mar 22 2019, 1:53 PM

Oh did more research. The command line option only applies to the session that you launched it with. It doesn't save the state, so this should probably be fixed

JoshStrobl changed the task status from Open to In Progress.Mar 23 2019, 8:01 PM
JoshStrobl triaged this task as Normal priority.
JoshStrobl moved this task from Backlog to Improvement on the Software board.

I'll get the proposed APIs listed in our product.json but not sure if you'll still need the extension itself from the marketplace (you probably will).

Copyright © 2015-2021 Solus Project. The Solus logo is Copyright © 2016-2021 Solus Project. All Rights Reserved.