Page MenuHomeSolus

New pyflakes breaks Flake8
Closed, ResolvedPublic

Description

After running the most recent updates I hit a problem with flake8.

After:

pyflakes is upgraded from 2.0.0-5-1-x86_64 to 2.1.0-6-1-x86_64 with delta.

Now flake8 breaks when run:

 $ flake8 -h
Traceback (most recent call last):
  File "/usr/bin/flake8", line 6, in <module>
    from pkg_resources import load_entry_point
  File "/usr/lib/python2.7/site-packages/pkg_resources/__init__.py", line 3123, in <module>
    @_call_aside
  File "/usr/lib/python2.7/site-packages/pkg_resources/__init__.py", line 3107, in _call_aside
    f(*args, **kwargs)
  File "/usr/lib/python2.7/site-packages/pkg_resources/__init__.py", line 3136, in _initialize_master_working_set
    working_set = WorkingSet._build_master()
  File "/usr/lib/python2.7/site-packages/pkg_resources/__init__.py", line 580, in _build_master
    return cls._build_from_requirements(__requires__)
  File "/usr/lib/python2.7/site-packages/pkg_resources/__init__.py", line 593, in _build_from_requirements
    dists = ws.resolve(reqs, Environment())
  File "/usr/lib/python2.7/site-packages/pkg_resources/__init__.py", line 781, in resolve
    raise DistributionNotFound(req, requirers)
pkg_resources.DistributionNotFound: The 'pyflakes<2.1.0,>=2.0.0' distribution was not found and is required by flake8

Someone allowed a pyflakes update through without updating flake8 as well.

Event Timeline

flake8 3.6.0 is the latest release. The problem is the stupid upper bond check they put on version numbers.
I saw some distro removes them to prevent stupid breakage when a dependency is updated as it seems to cause more problems than it actually solves.

I'll have a look at it in the evening if nobody else fix it in the meantime.

Girtablulu edited projects, added Software; removed Lacks Project.
Girtablulu moved this task from Backlog to Package Fixes on the Software board.
JoshStrobl raised the priority of this task from Normal to High.Jan 29 2019, 11:04 AM
JoshStrobl added a subscriber: JoshStrobl.

This should not have been broken in the first place @kyrios123

Here on out, unit tests are not acceptable means of "testing". Any further patches I see that are strictly "Unit tests work" will be immediately marked as abandoned.

@Girtablulu I don't sadly have a safe environment setup where I can test this, and running sudo to install a package from an unofficial source on a work machine is sadly a nope from me. :(

It's easy enough to test, just install and run flake8. Even flake8 -h should be enough to trigger this error.

Does seem fixed by:
https://dev.getsol.us/R762:d11ab2cf5eb242271dcfc0457112ea2d7c74edd9

I had to reinstall pycodestyle and pyflakes, although I have a feeling needing to do that was my own fault.

Girtablulu claimed this task.