Page MenuHomeSolus

Qogir GTK Theme
Closed, WontfixPublic

Description

Name: Qogir Gtk Theme
Homepage: https://github.com/vinceliuice/Qogir-theme
Why: It's the best GTK+ theme IMHO, and goes well with Solus. Also, has support for Budgie DE.
Open Source
I think this will be very popular, as it's a beautiful theme.
Link to Package: https://github.com/vinceliuice/Qogir-theme/archive/2018-11-12.tar.gz

Event Timeline

Jacalz added a subscriber: Jacalz.Jan 21 2019, 4:10 PM

Please update the description to follow the documentation here

MonkeyBootey updated the task description. (Show Details)Jan 21 2019, 5:54 PM

This is my first request, please let me know if I am still missing anything.

Jacalz updated the task description. (Show Details)Jan 21 2019, 5:57 PM

It was alright apart from it not using the tarball from the latest release. I updated the description so it should be fine now 🙂

MonkeyBootey added a comment.EditedJan 21 2019, 6:27 PM

Thank you.

royyhlee added a subscriber: royyhlee.

I'm currently testing this theme, and I have to say, I am certainly intrigued.
This is the first theme that has almost convinced me to stop using Arc (the close button looks out of place in Firefox with a theme, and I prefer Arc's grey to Qogir's white titlebars, though I would prefer blue, if done properly).

bwat47 added a subscriber: bwat47.Jan 23 2019, 6:50 PM
watpi added a subscriber: watpi.Jan 24 2019, 10:14 AM

Looks pretty Solus-y to me.

JoshStrobl triaged this task as Wishlist priority.Jan 24 2019, 11:15 AM
JoshStrobl moved this task from Backlog to Awaiting Package Upgrades on the Package Requests board.
JoshStrobl added a subscriber: JoshStrobl.

I'd like to see a new release featuring support for latest Budgie git first.

Also not a requirement for inclusion, but descriptive git commit messages would be nice too.

kyrios123 removed kyrios123 as the assignee of this task.
kyrios123 added a subscriber: kyrios123.
Lorien added a subscriber: Lorien.Jan 25 2019, 1:01 AM
zerocon added a subscriber: zerocon.May 3 2019, 1:26 PM
This comment was removed by zerocon.
zerocon claimed this task.May 4 2019, 3:37 AM

I just noticed the whole deal and went through related threads and how people submitted the package but were rejected due to:

a new release featuring support for latest Budgie git first.

Mind elaborate more about that? maybe sth I can report to the original dev... what about yesterday's release?
Anyway apologies if I messed up. Should I abandon the package?

Since this was my first submit, any notes on the packaging itself for the future would be nice (even if it got rejected)

a new release featuring support for latest Budgie git first

It means that the developer has to first release a new version with official support for the latest development version of Budgie.

Probably not, but is this enough, @JoshStrobl?

2019-05-03

@vinceliuice vinceliuice released this 14 days ago · 2 commits to master since this release

Fixed gnome-shell issues
Fixed budgie-panel issues
Fixed cinnamon issues

algent added a subscriber: algent.May 25 2019, 10:24 PM
This comment was removed by algent.
algent changed the task status from Open to In Progress.Aug 29 2019, 3:42 PM
algent claimed this task.
Justin added a subscriber: Justin.Sep 4 2019, 2:46 AM

@algent if you'll be maintaining this I can remove the Needs Maintainer tag.

That tag shouldn't be removed. When the patch lands and this issue is resolved, that's a clear indication there is a maintainer.

algent added a comment.Sep 4 2019, 6:58 AM

Yes @Justin i will maintain this, after this patch is accepted.

New version released. 2019.10.25

  • Fixed Budgie popover menu border
  • Fixed gnome-control-centry issues
  • Fixed Mate desktop issues
  • Fixed gnome-shell 3.34 issues
  • Add support for gdm theme
  • Fixed gnome-shell search results issue
  • Fixed geary issues

I will update the diff if this gets changed from Wishlist to Normal.

I will update the diff if this gets changed from Wishlist to Normal.

Not going to change the priority. Priority is used as a guideline, not a requirement. You can submit a patch either way.

JoshStrobl closed this task as Wontfix.EditedWed, Jan 29, 2:49 PM
JoshStrobl removed a project: Needs Maintainer.
JoshStrobl moved this task from Accepted For Inclusion to Backlog on the Package Requests board.

Closing as wontfix and moving away from accepted for inclusion. The two provided patches were closed, first with a vague "not yet time for this" response to feedback and another for not replying to feedback.

Not seeing any upstream releases that make it clear whether a new release is warranted (and thus if we should wait) and the development practices of the developer of the theme would only make it difficult for us to audit ongoing changes (a significant portion of the commits literally just have the commit message as "update" with no additional context provided).