Page MenuHomeSolus
Create Task
Maniphest T7395

Make gimp use system theme
Closed, ResolvedPublic
Actions

Assigned To
None
Authored By
so-lo
Dec 25 2018, 10:59 PM
Tags
Referenced Files
F4258844: Screenshot from 2018-12-25 23-39-19.png
Dec 25 2018, 10:59 PM
F4258845: Screenshot from 2018-12-25 23-39-53.png
Dec 25 2018, 10:59 PM
Subscribers
JoshStrobl
so-lo
Triage Team
Tokens
"Yellow Medal" token, awarded by kyrios123."Like" token, awarded by Jacalz."Like" token, awarded by Staudey.

Description

The default look of gimp seems a little unexpected to me. The dark background doesn't match the desktop theme and the icons are quite huge.

Screenshot from 2018-12-25 23-39-19.png (1×1 px, 214 KB)

The settings allow to make it use the system theme and also inherit icon sizes from there which I found to be a lot more pleasant on the eye.

Screenshot from 2018-12-25 23-39-53.png (1×1 px, 232 KB)

It seems that the defaults can be configured through /etc/gimp/2.0/gimprc so I wanted to propose to make this configuration part of the Solus package.

Revisions and Commits

R907 gimp
D4865R907:abd654bed91b Customise theme and icons

Event Timeline

so-lo created this task.Dec 25 2018, 10:59 PM
Staudey awarded a token.Dec 26 2018, 12:24 AM
Jacalz awarded a token.Dec 26 2018, 7:25 AM
JoshStrobl triaged this task as Low priority.EditedDec 26 2018, 10:06 AM
JoshStrobl moved this task from Backlog to Improvement on the Software board.
JoshStrobl added a project: Low Hanging Fruit.
JoshStrobl added a subscriber: JoshStrobl.

Approved. If someone (read the IMPORTANT bit after) wants to patch the gimprc file and provide a package update patch for it while I'm "away" on holidays, go for it. Otherwise I can when I'm "back". Here's the steps:

  1. Clone the GIMP repo. No, I don't care that what I linked isn't GitLab. It's fine.
  2. Check out the 2.10.8 tag: git checkout GIMP_2_10_8 should do the trick
  3. Make the change to etc/gimprc.in in their tree. You should uncomment (theme "Dark") by removing the # (minding the whitespace, remove it too) and change it to (theme "System")
  4. Save the file and make a git commit. Plenty of docs online if you don't know how.
  5. Make a patch using git format-patch -n1. It'll look like 0001-Blah.patch
  6. Clone R907 gimp, bump it so it has an incremented relnum. See our Updating an Existing Package doc.
  7. Move the patch file from the gimp source repo to our repo, in a files directory that you'll need to create.
  8. Apply the patch (see our documentation), build, install the eopkg, test.
  9. Submit the patch following our documentation.
IMPORTANT: To those in #developers, please leave this for someone with little to no packaging experience to do (I'll abandon your patch if you ignore this). This is not a high priority item and it should provide a good starting point to packaging or at least some good practice. If you've never set up a build environment before for packaging, please consult our documentation.
so-lo added a revision: D4865: Customise theme and icons.Dec 28 2018, 7:16 PM
so-lo added a comment.Dec 28 2018, 7:20 PM

I packaged before but not on Solus so I think I still fall into the required noob category. :)

I walked through the steps above and the help center docs and hope that I didn't forget anything. Please let me know if something in https://dev.getsol.us/D4865 needs fixing.

JoshStrobl closed this task as Resolved by committing R907:abd654bed91b: Customise theme and icons.Dec 29 2018, 1:47 PM
JoshStrobl added a commit: R907:abd654bed91b: Customise theme and icons.
JoshStrobl added a comment.Dec 29 2018, 1:58 PM

Solid work @so-lo =)

kyrios123 awarded a token.Dec 29 2018, 2:14 PM
Copyright © 2015-2021 Solus Project. The Solus logo is Copyright © 2016-2021 Solus Project. All Rights Reserved.