Page MenuHomeSolus

[RFC] add a "new tab" Desktop Action to Firefox
Closed, ResolvedPublic

Description

Hello everyone,
As of T7289, I want to make a new Desktop Action which allows to open a new tab on Mozilla Firefox. It can easily be done using firefox --new-tab.
There is already a pending request on their bug tracker [0].
However, this issue is rather old and has not been fixed. As such, I think it will be faster to integrate it to Solus directly.
So if Solus devs approve my request, then I would be very happy to provide you the necessary patch.

[0] : https://bugzilla.mozilla.org/show_bug.cgi?id=1323666

Details

Commits
Restricted Differential Revision / R755:90a455e43082: Update firefox to 64.0 to address multiple CVEs

Event Timeline

Assigning JoshStrobl to investigate and triage. Referencing T7289.

  • Herald, our Phabricator bot
JoshStrobl closed this task as Wontfix.Dec 10 2018, 11:49 PM

Unfortunately it does not appear that --new-tab in fact opens up a new tab, at least in 63.0.3-145, whether it's using --new-window to open up the instance or not.

josephscade added a comment.EditedDec 11 2018, 7:50 AM

You're right, by default, --new-tab has a strange behaviour.
However, if you run firefox --new-tab about:newtab, it runs as excepted.

josephscade reopened this task as Open.Dec 11 2018, 8:17 AM
JoshStrobl triaged this task as High priority.
JoshStrobl added subscribers: kyrios123, JoshStrobl.

Can confirm it works as expected. @kyrios123 Let's get this added to the Desktop Actions in files/firefox.desktop for your 64.0 patch.

Update Actions to Actions=new-window;new-private-window;new-tab;

Add the following after the new-private-window desktop action (with a new line between them):

[Desktop Action new-tab]
Name=Open a New Tab
Exec=firefox --new-tab about:newtab
kyrios123 added a revision: Restricted Differential Revision.Dec 12 2018, 7:29 AM