Page MenuHomeSolus

Update "Etcher" to 1.4.8
Closed, ResolvedPublic

Description

CrackedCrafterz triaged this task as Normal priority.Nov 8 2018, 7:39 AM
CrackedCrafterz removed a project: Package Requests.
joebonrichie added a subscriber: joebonrichie.

They're using ssh submodules will have fork just to clone it with solbuild - so irritating.

Don't triage tasks by the way @CrackedCrafterz.

Jacalz added a subscriber: Jacalz.EditedNov 8 2018, 4:38 PM

I tried building this and had some errors with the git sub modules since the release tarball are unbuildable. Due to resin-io changing the name to balena-io. We will need to either build from a specific commit or wait for a new release. Applying a patch is not an option because the patch gets applied after git downloads the tarball...

But since a fork is needed for the ssh submodules, it isn’t a huge issue.

Dumb build hurdles to jump and electron apps, name a more iconic duo. Will have to checkout from commit 2907cd1.

Jacalz added a comment.Nov 8 2018, 5:47 PM

Electron apps really are terrible. I have sent in a PR in their repo to change over the sub modules to be fetched using https instead. Now we just need to wait and see if they merge it :)
Link to PR can be found here!

Jacalz added a comment.Nov 8 2018, 5:49 PM

I wouldn't mind taking this on after the PR get's merged, if it get's merged, and if it is okay for you of course @joebonrichie :D

Have at it, the make package-electron has been replaced by by make electron-build and you'll likely need to modify the build scripts to not to build a rpm package see here

Jacalz renamed this task from Update "Etcher" to 1.4.6 to Update "Etcher" to 1.4.8.Nov 23 2018, 9:07 PM

I am going to step down from this, the new Etcher changes are a pain to package and nothing is working like it should...

Jacalz removed Jacalz as the assignee of this task.Nov 24 2018, 2:24 PM