Page MenuHomeSolus
Create Task
Maniphest T6626

Get the RPATH out of my face
Closed, ResolvedPublic
Actions

Description

RPATHing binaries and libraries for absolutely no reason is catastrophic to the system and leading to issues such as T6084 T6530 and T6584

Time to RPATH off. Note this is a tracking bug, so don't start throwing up patches without talking to me.

libtool is...

  • Fix libtool directly or workaround it via LT_SYS_LIBRARY_PATH in solbuild as automake also makes life difficult. https://github.com/solus-project/ypkg/pull/60 should deal with this and successfully removes RPATH in libglvnd

Spreading RPATH via pkgconfig!:

openmpi (uses -Wl, --enable-new-dtags for RUNPATH which is probably acceptable!) has --disable-wrapper-rpath but uncertain whether you want to change its behaviour as you very well might be running external libraries when compiling with this. Leaving this as is

Should be harmless mentions and gone after rebuilds:

  • curl (inherits from kerberos)
  • ffmpeg (inherits from sdl2)
  • guile-32bit (maybe libunistring-32bit?)
  • gnutls-32bit (maybe libunistring-32bit?)

Intended:

  • ogre: -Wl,-rpath,${libdir}/OGRE
  • swipl: -Wl,-rpath=/usr/lib64/swipl-7.4.2/lib/x86_64-linux

REBUILDS

  • Rebuild revdeps of libglvnd and ensure packages don't RPATH (then nvidia 304 and 340 drivers should work correctly). Only a few obscure packages haven't so we'll call it done

This should also eradicate much of the RPATHing in Solus

Related Objects

Event Timeline

• sunnyflunk created this task.Jul 6 2018, 10:31 AM
• sunnyflunk claimed this task.Jul 6 2018, 10:35 AM
• sunnyflunk triaged this task as Unbreak Now! priority.
JoshStrobl added subscribers: ermo, JoshStrobl.Jul 6 2018, 12:32 PM

Working on kerberos at the moment since I need to sort it for a libsoup change anyways, so may as well kill two birds with one stone.

I'll make sure all the samba related bits are sorted post-sync when we're landing @ermo's patches, maybe he can be a kind soul and do those builds and update the patches. If not, no problemo.

JoshStrobl mentioned this in R1545:0854c89cf53b: Add rundeps for e2fsprogs devel subpackages for respective -devel and -32bit….Jul 6 2018, 12:35 PM
JoshStrobl updated the task description. (Show Details)Jul 6 2018, 12:35 PM
• sunnyflunk updated the task description. (Show Details)Jul 6 2018, 12:55 PM
ermo mentioned this in D3228: Update talloc to 2.1.13 (required by tevent 0.9.36) for Samba 4.7.8..Jul 6 2018, 2:31 PM
ermo mentioned this in D3229: Update tevent to 0.9.36 for Samba 4.7.8..
ermo mentioned this in D3230: Update tdb to 1.3.15 for Samba 4.7.8.Jul 6 2018, 2:33 PM
ermo mentioned this in D3231: Update ldb to 1.3.4 for Samba 4.7.8.
ermo mentioned this in D3232: Update Samba to 4.7.8 and change to more secure default settings..
• sunnyflunk added a comment.Jul 7 2018, 12:54 AM

There appears to be a secondary issue which accounts for the packages RPATHing that don't link via the pkgconfig flags...it's name is libtool and it's horrible. Some pretty odd methods of getting system paths such as /etc/ld.so.conf rather than ldconfig. The one method that actually seems to work is exporting LT_SYS_LIBRARY_PATH=%libdir% (to remove rpath of /usr/lib64). It would need to include the usual search paths /lib64 /lib /lib32 /usr/lib64 /usr/lib /usr/lib32

* When building on some GNU/Linux systems for multilib targets
  `libtool' sometimes guesses the wrong paths that the linker and
  dynamic linker search by default. If this occurs for the dynamic
  library path, you may use the `LT_SYS_LIBRARY_PATH' environment
  variable to adjust. Otherwise, at `configure' time you may
  override libtool's guesses by setting the `autoconf' cache
  variables `lt_cv_sys_lib_search_path_spec' and
  `lt_cv_sys_lib_dlsearch_path_spec' respectively.
• sunnyflunk updated the task description. (Show Details)Jul 7 2018, 1:33 AM
• sunnyflunk updated the task description. (Show Details)Jul 8 2018, 8:31 AM
livingsilver94 added a subscriber: livingsilver94.Jul 8 2018, 8:35 AM
Jacalz added a subscriber: Jacalz.Jul 8 2018, 6:17 PM
JoshStrobl updated the task description. (Show Details)Jul 12 2018, 10:36 AM
• sunnyflunk updated the task description. (Show Details)Jul 16 2018, 4:47 AM
Jacalz added a comment.Jul 16 2018, 10:33 AM

Is there any more advantages to this than the fact that things start working again?

• sunnyflunk added a comment.Jul 16 2018, 10:42 AM

I get my life back

Girtablulu awarded a token.Jul 16 2018, 10:51 AM
Jacalz added a comment.Jul 16 2018, 11:35 AM

Oh, I was hoping for something in the lines of speedier app startup or slightly better performance but I guess life is important too ??

• sunnyflunk added a comment.Jul 16 2018, 12:44 PM

It speeds up solving bugs so there's definitely efficiency gains

ermo awarded a token.Jul 18 2018, 2:40 PM
• sunnyflunk closed this task as Resolved.Jul 31 2018, 6:10 AM
• sunnyflunk updated the task description. (Show Details)

All that is to be done, is done now. It will be revisited in future and incidence will be severely reduced since first looked at this.

Copyright © 2015-2021 Solus Project. The Solus logo is Copyright © 2016-2021 Solus Project. All Rights Reserved.