Page MenuHomeSolus
Create Task
Maniphest T657

pantheon-terminal 0.4
Closed, ResolvedPublic
Actions

Description

0001-Update-to-0.4.patch3 KBDownload

Related Objects
Search...

StatusSubtypeAssignedTask
 ResolvedJoshStroblT657 pantheon-terminal 0.4
 ResolvedJoshStroblT655 granite 0.4.0.1

Event Timeline

blaz created this task.Sep 14 2016, 10:44 PM
JoshStrobl renamed this task from pantheon-files 0.4 to pantheon-terminal 0.4.Sep 14 2016, 11:11 PM
blaz added a comment.Sep 15 2016, 5:26 AM

0001-Updated-to-0.4.patch3 KBDownload

Fixed the license value

JoshStrobl added a subtask: T655: granite 0.4.0.1.Sep 15 2016, 8:25 AM
JoshStrobl added a subscriber: JoshStrobl.

Your patch needs to be rebased off the existing pantheon-terminal in the repo.

blaz added a comment.Sep 15 2016, 6:55 PM

0001-Updated-to-0.4.patch3 KBDownload

Rebased

JoshStrobl claimed this task.Sep 16 2016, 3:31 PM
JoshStrobl triaged this task as Normal priority.
JoshStrobl moved this task from Backlog to Ready For Merge on the Patch Submission board.

LGTM.

JoshStrobl closed subtask T655: granite 0.4.0.1 as Resolved.Sep 18 2016, 3:35 PM
JoshStrobl closed this task as Resolved.Sep 18 2016, 3:42 PM

Landed with your patch and follow-up that drops libnotify: https://git.solus-project.com/packages/pantheon-terminal/commit/?id=67a59c684cc78d6d35807b1bb5486cd75d7139d6

Thanks!

Copyright © 2015-2021 Solus Project. The Solus logo is Copyright © 2016-2021 Solus Project. All Rights Reserved.