Page MenuHomeSolus

Update Firefox to 59.0
Closed, ResolvedPublic

Event Timeline

bwat47 added a subscriber: bwat47.Mar 13 2018, 3:17 PM

If you could try re-enabling:-

ac_add_options --with-system-nspr
ac_add_options --with-system-nss

with D2496 and D2008, would be great

It would be cool to re-enable Stylo and test it with Speedometer. It should be mature enough now.

I too would like to see stylo enabled if the update passes regression testing

@ikey @sunnyflunk @JoshStrobl : Would it be fine if I build firefox against D1900 D2008 and D2496 (I'd like to avoid unecessary rebuilds since it's a plague to compile.

@livingsilver94 @tristan957 Benchmarks of all major versions of firefox are foreseen until stylo/servo finally gets faster than the legacy engine. Results will be published here

D1900 for sure (and it's been pushed), I thought the others were dropped from the firefox build cause it was broken? Kinda depends if it works with the updated nss/nspr. If they work with firefox, then go ahead.

kyrios123 added a comment.EditedMar 14 2018, 12:43 PM

D1900 for sure (and it's been pushed), I thought the others were dropped from the firefox build cause it was broken? Kinda depends if it works with the updated nss/nspr. If they work with firefox, then go ahead.

I quickly tried to enable it back and compile with nss & nspr 4.19, but the build failed:

0:13.06 checking NSPR selection... system
0:13.06 checking for nspr-config... /usr/bin/nspr-config
0:13.10 checking for NSPR - version >= 4.18... no
0:13.10 configure: error: you do not have NSPR installed or your version is older than 4.18.
0:13.12 DEBUG: <truncated - see config.log for full output>
0:13.12 DEBUG: configure:8957:26: error: conflicting types for 'malloc_usable_size'
0:13.12 DEBUG: In file included from configure:8955:0:
0:13.12 DEBUG: /usr/include/malloc.h:134:15: note: previous declaration of 'malloc_usable_size' was here
0:13.13 DEBUG:  extern size_t malloc_usable_size (void *__ptr) __THROW;
0:13.13 DEBUG:                ^~~~~~~~~~~~~~~~~~
0:13.13 DEBUG: configure: failed program was:
0:13.13 DEBUG: #line 8954 "configure"
0:13.13 DEBUG: #include "confdefs.h"
0:13.13 DEBUG: #include <malloc.h>
0:13.13 DEBUG:                   #include <stddef.h>
0:13.13 DEBUG:                   size_t malloc_usable_size(const void *ptr);
0:13.13 DEBUG: int main() {
0:13.13 DEBUG: return malloc_usable_size(0);
0:13.13 DEBUG: ; return 0; }
0:13.13 DEBUG: configure:8985: checking for valloc in malloc.h
0:13.13 DEBUG: configure:9010: checking for valloc in unistd.h
0:13.13 DEBUG: configure:9165: checking NSPR selection
0:13.13 DEBUG: configure:9265: checking for nspr-config
0:13.13 DEBUG: configure:9300: checking for NSPR - version >= 4.18
0:13.13 DEBUG: configure: error: you do not have NSPR installed or your version is older than 4.18.
0:13.13 ERROR: old-configure failed

@kyrios123 you might have to symlink the pkgconfig as mozilla-nspr e.g. ln -s nspr.pc $installdir/usr/%libdir%/pkgconfig/mozilla-nspr.pc or not use the pkgconfig use nspr-devel

JoshStrobl triaged this task as Normal priority.Mar 15 2018, 4:16 PM
JoshStrobl moved this task from Backlog to Improvement on the Software board.