Page MenuHomeSolus

i3lock-fancy
Closed, WontfixPublic

Description

Name: i3lock-fancy
Homepage: https://github.com/meskarune/i3lock-fancy
http://meskarune.github.io/i3lock-fancy/
Why? As the name says, it is a fancier version of i3lock which is in the repositories. I've seen it in action and it looks awesome.
Open source: yes
Source: https://github.com/meskarune/i3lock-fancy/archive/0.2.tar.gz

JoshStrobl triaged this task as Normal priority.
JoshStrobl added a subscriber: JoshStrobl.

For those packaging this: I do not want a separate fork of i3lock in the repo. Please change our i3lock to use the i3lock-color fork that is linked in the i3lock-fancy GitHub README. Also the binary needs to change from lock to i3lock-fancy or similar, I do not accept lock as a valid binary name because it's too generic.

JoshStrobl reopened this task as Open.Dec 15 2017, 8:30 PM
JoshStrobl added a subscriber: feskyde.

Re-opening. @feskyde, please fix your i3lock commit and properly test it. No illegal instructions or segfaults, no memory leaking.

Re-opening. @feskyde, please fix your i3lock commit and properly test it.

Do I need to create a new patch or just update D1645?

You can update the closed patch

@feskyde Thanks for working on this. I am not sure if it is safe to install from the software-center or is it already patched?

@feskyde Thanks for working on this. I am not sure if it is safe to install from the software-center or is it already patched?

The i3lock package installs the original i3lock so you will end with a broken i3lock-fancy. Do not install it yet.

So I got this response from PandorasFox:

There'll be some leaks reported in Valgrind.

There's some discussion in i3#168 - this is sorta intentional. We can do some cleanup at exit, but it complicates the code and doesn't really matter that much, since the OS handles that memory anyways. There's no leaks that occur more than once (i.e. all the leaked memory is only leaked once, so it's less of a leak and more of a "not bothering to clean up memory at exit, to keep the code cleaner/easier to maintain").

i3lock-color issue: https://github.com/PandorasFox/i3lock-color/issues/70
i3lock pull request: https://github.com/i3/i3lock/pull/168

Well regardless of where the issue lies, we're not switching back to i3lock-color until it or its upstream i3lock resolves the issue.

feskyde removed feskyde as the assignee of this task.Jul 3 2018, 1:23 AM
JoshStrobl closed this task as Wontfix.Jul 29 2018, 5:30 PM
JoshStrobl claimed this task.

Given the lack of movement on this and it being broken in our repository, this is being pulled from the repo and being marked WONTFIX.