Page MenuHomeSolus
Create Task
Maniphest T442

platformIO
Closed, ResolvedPublic
Actions

Description

hello just another package.

0001-Commit.patch18 KBDownload

Related Objects
Search...

StatusSubtypeAssignedTask
 ResolvedJoshStroblT215 platformIO
 ResolvedJoshStroblT442 platformIO

Event Timeline

BearzR created this task.Sep 2 2016, 12:20 PM
JoshStrobl added a parent task: T215: platformIO.Sep 2 2016, 12:36 PM
JoshStrobl added a subscriber: JoshStrobl.Sep 3 2016, 2:39 PM
  • License needs to be fixed to Apache-2.0, which is SPDX complaint.
  • Setup section should be removed since there isn't anything there.
  • You should also use our Python actionable macros, documented here.
BearzR added a comment.Sep 10 2016, 2:35 AM

I'm sorry this took so long. I fixed the issues that you had and update it to the latest release that came out 2 days ago.

0002-Fix-build-latest-version.patch22 KBDownload

DataDrake added a subscriber: DataDrake.Sep 10 2016, 12:56 PM

@BearzR Since this patch is for the creation of a new package, it should be at release 1 and the commit message should be along the lines of "Initial working platformIO".

BearzR added a comment.Sep 10 2016, 1:02 PM

0001-Initial-working-platformIO.patch15 KBDownload

DataDrake added a comment.Sep 10 2016, 1:05 PM

You have to rebuild, else the pspec doesn't get updated.

BearzR added a comment.Sep 11 2016, 12:20 PM

Just got done rebuilding it.

0001-Inital-Wroking-Version.patch15 KBDownload

JoshStrobl claimed this task.Sep 20 2016, 5:24 PM
JoshStrobl triaged this task as Normal priority.
JoshStrobl moved this task from Backlog to Ready For Merge on the Patch Submission board.

LGTM. Though I don't know what "wroking" is /trollface

JoshStrobl closed this task as Resolved.Sep 25 2016, 2:09 AM

Landed as of https://git.solus-project.com/packages/platformio/commit/?id=933702915d749e41572de72c4e35c045b1a71194

Thanks!

Copyright © 2015-2021 Solus Project. The Solus logo is Copyright © 2016-2021 Solus Project. All Rights Reserved.