Page MenuHomeSolus

xbacklight
Closed, ResolvedPublic

Description


xbacklight patch so i3 users can change there backlight on there lcd screens :)

Event Timeline

crash created this task.Aug 28 2016, 12:47 PM
JoshStrobl claimed this task.EditedAug 28 2016, 1:53 PM
JoshStrobl triaged this task as Normal priority.
JoshStrobl added a subscriber: JoshStrobl.

Huh yea...didn't even notice backlighting didn't work on my laptop testing i3. Nice catch, I'll get this merged in. You think this should be a rundep of i3, for that better integrated experience and everything just "working" OOTB?

Regarding patch, custom isn't a valid LICENSE. Guessing you got that bit from arch?

crash added a comment.Aug 28 2016, 2:16 PM

Yeah i think it would be nice to have that as a rundep of i3 so users get it directly instead of hunting it down :P i was not sure of the license so looked what arch did on that part and i did not know what i should write as a license :(

Update, we already have an xbacklight git repo, please ensure your patch applies on top of it. Meanwhile, if you could fix the license to MIT that'd be appreciated.

crash updated the task description. (Show Details)Aug 28 2016, 8:17 PM

hmm not sure how i can test that?

I have built and installed this one and i'm using it now :) and the patch is updated with MIT license.

Before i tried to package this i did eopkg sr xbacklight and got nothing back, so i did't know there was another xbacklight in there somewhere.

You need to clone the existing repo from http://git.solus-project.com/packages and make changes in the clone, then commit and create the patch for the new revision.

crash added a comment.EditedAug 28 2016, 8:29 PM

but that one has some actions.py that i'm not using in my xbacklight dir.

but that one has some actions.py that i'm not using in my xbacklight dir. that was what i was unsure about!

You need to git rm the old stuff and make sure those removes are in the same commit as your new files.

crash updated the task description. (Show Details)Aug 28 2016, 8:34 PM

Alright patch updated, i think i did it right i hope :)

Looks good to me!

crash added a comment.Aug 28 2016, 8:41 PM

Great! Thanks :)

JoshStrobl closed this task as Resolved.Aug 28 2016, 8:42 PM

Landed!