Page MenuHomeSolus

flow-pomodoro
Closed, ResolvedPublic

Description

Initial working patch of flow-pomodoro

Note: the .desktop file sets as icon "kmines". We don't have that icon, so I changed it for the icon.png in the source directory (found this solution better than having no icon at all)...

Related Objects

StatusSubtypeAssignedTask
ResolvedJoshStrobl
ResolvedJoshStrobl

Event Timeline

  1. Component could probably be office like gnome-pomodoro.
  2. Not sure why you're doing an install call then cp'ing. Just do two install calls, and drop the mkdir bit. install doesn't move the file, it copies them, so it'll still be in src/img.

Thanks Joshua, I removed the unnecesary bits. In fact, I realized there's a .svg file too, so I used this one instead of the 128x128 png. Think this makes more sense as it's scalable? (I had a look at the freedesktop specs doc about application icons and they seem to recommend using the .svg when available).

Attaching new patch. Thanks for the review!

JoshStrobl moved this task from Awaiting Fixes to Ready For Merge on the Patch Submission board.

Yea using the scalable makes much more sense. Patch looks good to me, nice work!