Openbox set up for Solus. Includes menu edited for ease of use with Solus defaults.
Description
Description
Event Timeline
Comment Actions
- Not sure what is up with your commit message. It should be something like 'Initial commit of openbox'. I'm assuming you put the abi_symbols content in there, which isn't how that's supposed to go. Look at our patch submission document.
- Care to explain the menu.xml file? Do they not ship with their own?
- You don't need the absolute path for the desktop file, and having Exec and TryExec is redundant given they're the same.
- builddeps need to be re-evaluated. A bunch of those are reverse dependencies or dependencies of each other or are part of system.devel
- You need to disable static libraries via configure.
- You have too much spacing in the beginning of your description.
- Is that libtool call actually necessary?
- You should combine -D -m in your desktop call to just -Dm and specify a mode for your menu.xml file.
Comment Actions
- Will edit that all up for you.
- Edited the menu.xml file so that it would work with the default terminal on Solus Mate and so that the software center would be added to it by default for ease of use.
- Will look into this and fix it up
- definitely forgot about that, just put in all the deps by reading from the recommendatins on the openbox website
- Will look into this
- Yes
- I believe so, at least that's why my research told me inorder to get the package to build in 64bit.
- Will do and I'll look into how to specify a mode for my menu.xml
thank you for the feedback :D
Comment Actions
Thanks @catman1900 for the updated patch.
- Your description still doesn't have incorrect spacing. Use 4 spaces =)
- libxft-devel has a pkgconfig, please use that.
- desktop file Exec should still just be openbox rather than the path to the binary
- I'm guessing -D wasn't needed since the paths were already created from make_install, so the install calls look good now.
Comment Actions
- Now uses 4 spaces!
- The packages refuses to compile if libxft-devel isn't named explicitly, I have no clue why but I was unable to find a solution.
- fixed!
- glad my install calls were fixed.
Every menu attempt I tried for was incredible painful and failed to execute so as an alternative given this package is submitted I have obmenu packaged also ready to submit to allow for easy menu editing
Comment Actions
- libxft-devel --> pkgconfig(xft) is what @JoshStrobl meant.
Not sure why you are running libtool. You should try commenting it out to see if it has an effect on the build.
Comment Actions
- Alright I've changed libxft-devel to pkgconfig(xft) and now it will compile successfully with it so that's all squared away.
Also removed libtool for the install calls and this had no negative effects to the compilation so I'll leave it out to keep it clean and proper.
Comment Actions
So @catman1900, in the future, don't list file names in the commit message. It's obvious because it is in commit itself.
Landed in unstable as of https://git.solus-project.com/packages/openbox/commit/?id=6675880962cc6305f329d2cb0a83352d35d043c5