Page MenuHomeSolus

Certbot
Closed, ResolvedPublic

Description

Name: Certbot
Homepage: http://certbot.eff.org/
Why should this be included in the repository? Some discussion took place on T2882. To summarize: some people (myself included) have websites that require us to generate Let's Encrypt certificates on our desktops/laptops and upload them to the web server. This package generates the certificates. Other clients exist, but this is the official reference implementation.
Is it Open Source: yes
How many users do you anticipate will use this software? As many as have websites requiring SSL certificates.
Link to source tarball/zip file: https://github.com/certbot/certbot/archive/v0.12.0.zip

Event Timeline

Shadow53 created this task.Mar 27 2017, 9:45 PM
siru added a subscriber: siru.Mar 28 2017, 8:04 PM
DataDrake triaged this task as Normal priority.Apr 5 2017, 8:53 PM
DataDrake moved this task from Backlog to Accepted For Inclusion on the Package Requests board.

I thought I would try to package certbot myself and put the patch up here. So far I've come across 10 unpackaged python library dependencies, one of whose error message is

pkg_resources.DistributionNotFound: The 'ipaddress' distribution was not found and is required by cryptography

python-cryptography is already in the repos but the dependency of python-ipaddress is not. Thus I have two questions for @DataDrake or @JoshStrobl:

  1. Is there a point where too many dependencies makes a package unable to be included?
  2. Do package requests need to be made for all of these packages, or just patches, since certbot has been accepted?
  3. In the case of the ipaddress library, would the dependency be added to python-cryptography or whichever piece requires python-cryptography?
  4. If it would be added to python-cryptography, should I just post a patch?
  1. No. See the list in the comments: T459: Haskell. That was just for haskell-stack
  2. Just patches
  3. Deps get added to the things that directly use them.
  4. Yes.
BearzR added a subscriber: BearzR.Apr 5 2017, 11:50 PM
Shadow53 added a comment.EditedApr 15 2017, 11:36 PM

Okay, well I have some patches to add for various dependencies for certbot. Since I started trying to package it, they released a new version that seems to have added a dependency on argparse which, as far as I can tell, is supposed to be bundled with Python 2.7, but running certbot errors without the extra python-argparse package.

[Removed the patches I put here and put in subtasks]

@Shadow53 These are supposed to go in separate patch submission tasks. Not on a package request. https://solus-project.com/articles/packaging/submitting-a-package/en/

There are some dependencies that require one or more of the current subtasks to land before running make will work. Should I wait or upload the other patches based on them working when I used ypkg?

You shouldn't upload a patch where you use ypkg as it hasn't been validated properly.

You should instead use a local repository as per the help center documentation https://solus-project.com/articles/packaging/local-repository/en/

JoshStrobl closed subtask T3297: python-funcsigs as Resolved.

I'm not sure if I need to make another issue as before or if the diff takes the place of that, but python-configargparse is diff D68