Page MenuHomeSolus
Create Task
Maniphest T2938

swh-plugins
Closed, ResolvedPublic
Actions

Description

Patch for swh-plugins

0001-Initial-commit-of-package-swh-plugins.patch10 KBDownload

Related Objects
Search...

StatusSubtypeAssignedTask
 ResolvedJoshStroblT2777 swh-plugins
 ResolvedJoshStroblT2938 swh-plugins

Event Timeline

euoar created this task.Mar 18 2017, 7:40 PM
JoshStrobl moved this task from Backlog to Awaiting Fixes on the Patch Submission board.Mar 20 2017, 8:57 PM
JoshStrobl added a subscriber: JoshStrobl.

%configure is redundant, our %autogen macro calls configure. Otherwise LGTM.

euoar added a comment.Mar 20 2017, 10:48 PM

I know it should be enough with %autogen, but if I remove the %configure part it fails with this message:

line 32: --infodir=/usr/share/info: No such file or directory

Don't know the reason of this... I'll look into it.

euoar added a comment.EditedMar 21 2017, 1:34 AM

So, I couldn't find the reason :/ I'm attaching a patch changing the %autogen macro for ./autogen, so at least we get rid of the redundant configure bit. Is it ok so? (and now finally going to sleep)

0001-Initial-commit-of-swh-plugins.patch10 KBDownload

JoshStrobl claimed this task.Mar 21 2017, 11:40 AM
JoshStrobl moved this task from Awaiting Fixes to Ready For Merge on the Patch Submission board.

Is it ok so?

Yea don't sweat it, not your fault they can't handle all the CONFOPTS. LGTM.

JoshStrobl closed this task as Resolved.Mar 21 2017, 11:42 AM

Landed in unstable as of https://git.solus-project.com/packages/swh-plugins/commit/?id=85913644506168e89336b584fbc1ece64fcdf5d8

Copyright © 2015-2021 Solus Project. The Solus logo is Copyright © 2016-2021 Solus Project. All Rights Reserved.