Page MenuHomeSolus

Closed, ResolvedPublic


Klavaro typing tutor packaging.

Event Timeline

shameempk updated the task description. (Show Details)Aug 18 2016, 5:20 PM
shameempk updated the task description. (Show Details)
JoshStrobl triaged this task as Normal priority.Aug 19 2016, 10:44 AM
JoshStrobl added a subscriber: JoshStrobl.

A few things:

  1. If the LICENSE is GPL-3.0, please remove the # CHECK ME
  2. The GTK and GDK pkgconfigs are redundant. You don't need to specify both, just one.
  3. Check the dependencies of libgtk-3-devel and you'll see it needs pango, thus you don't need the pango pkgconfig.
  4. Don't include commented out pkgconfigs, just remove the line entirely.
  5. Your package contains static dependencies, those need to be disabled during configure.

almost :D

Looks good to me!