Page MenuHomeSolus

abcMIDI
Closed, ResolvedPublic

Description

First time packaging software, so hope the patch is ok...

abcMIDI is very useful software for anyone who plays a music instrument - though most popular, perhaps for traditional music -. It includes a set of command line utilities to work and transform abc notation files, midi, etc.

From sourceforge: "Abcmidi is a package of programs supporting the ABC Music Notation Format (see http://abcnotation.com ). There are numerous programs included. For example, abc2midi converts an abc file to a MIDI file, midi2abc converts a midi file to an abc file, abc2abc transposes the music to a different key, yaps creates a Postscript file containing the music notation, midicopy copies a selected portion of a MIDI file, and abcsearch searches an abc file for specific musical patterns."

Related Objects

Event Timeline

euoar updated the task description. (Show Details)

Fixed an error in previous patch. Attaching the corrected patch.

JoshStrobl triaged this task as Normal priority.EditedFeb 27 2017, 8:37 PM
JoshStrobl moved this task from Backlog to Awaiting Fixes on the Patch Submission board.
JoshStrobl added a subscriber: JoshStrobl.
  1. /usr/local isn't an acceptable path. Please fix this using --prefix=/usr during configure.
  2. Change the license to be license : GPL-2.0, no need for it to be in a list.
  3. You can probably just nuke the doc folder in share. Something like rm -r $installdir/usr/share/doc in the install step after the make install, given there is the man files and the docs are mostly licensing, history, etc.
  4. The configure is a blatant copy of the nano example from Package.yml documentation. You likely don't need either of those flags and you should evaluate the actual configure flags of the program you're packaging.
  5. You have a line break between description and setup that should be removed.
This comment was removed by euoar.

Thank you for the tips and corrections.

%configure --prefix=/usr didn't seem to fix the problem with the path, until I realised the source code is including already a generated "makefile" appart from the "Makefile.in", so I added a line removing the "makefile" to make it work... I asume that this is ok, as %configure already creates a Makefile, and make would choose "makefile" over "Makefile" if both were present.

Sorry for the noob errors...

Attaching new patch.

JoshStrobl moved this task from Awaiting Fixes to Ready For Merge on the Patch Submission board.

Sorry for the noob errors...

It's perfectly fine, we all start somewhere! The patch looks great now, nice work :)

Ignoring my derp and landing the wrong patch, resolved that and landed the corrected one as of: https://git.solus-project.com/packages/abcMIDI/commit/?id=d7237dea89616cb28f224b07a9e1a1d06fe2f476

Sorry for the noob errors...

It's perfectly fine, we all start somewhere! The patch looks great now, nice work :)

Thanks! :)