Page MenuHomeSolus

Kitematic
Closed, ResolvedPublic

Description

Initial package creation of Kitematic.

Related Objects

StatusSubtypeAssignedTask
ResolvedJoshStrobl
ResolvedJoshStrobl

Event Timeline

Couple of things:

  1. I'm not sure if system.utils is the right component for this. It seems more like something for programming.tools
  2. You don't need binutils as a builddep. It's part of system.base.
  3. Just use install -d <dirname> for directory creation. It automatically sets 00755 as the permissions. The same goes for /usr/share.
  4. You should be using 00644 and 00755 for files modes. The leading 0's are important.
  5. The symlink creation should be the following or else it won't work:
ln -s /usr/share/kitematic/Kitematic $installdir/usr/bin/kitematic

Don't worry about a warning during the build for that symlink, it can't find it because it isn't actually there until it is installed. That's all.

Sure thing. Also changed the license to the correct one.

@DataDrake, just to let you know I have updated my patch as you instructed.

JoshStrobl added a subscriber: JoshStrobl.
  1. Does this need Docker for building? There some sort of libraries Kitematic needs from Docker? If neither, that could be removed from builddeps.
  2. If nodejs is needed for building, it's gonna be needed for running too, so that needs to be a rundep.

Hey @JoshStrobl,

  1. Good point. I can investigate this.
  2. Build process uses electron-prebuilt to build the app, so I believe this is already contained in the final application.

I will let you guys know how it goes.

Hey guys, sorry for the delay. It has been a few super busy days.

So here is my findings:

  1. No it doesn't need Docker to be built.
  2. The app brings it's own nodejs runtime. It does not need a nodejs runtime to be preinstalled.

The updated patch:

Outside of the *really minor* issue that the description should be after the summary and before the builddeps, this patch looks good to me. Solid work!

Thank you @JoshStrobl! Here is the updated patch.

I think you uploaded the wrong patch, that doesn't address the issue.

Ah sorry for the trouble. It was the end of the week.

JoshStrobl moved this task from Awaiting Fixes to Ready For Merge on the Patch Submission board.

No problem :D The patch looks good, thanks for the work on this. Enjoy your weekend!

Currently apply work on top of the patch. It's evident now that this wasn't build with solbuild. Please do so in the future.