Page MenuHomeSolus
Create Task
Maniphest T2588

Riot 0.9.7 Initial commit
Closed, ResolvedPublic
Actions

Description

Took a run at packaging riot. Electron was a bit of a pain but I think I got it figured out.

0001-Initial-commit-of-riot.patch10 KBDownload

Note: For component I placed this in network.im as riot works as a messaging app. It can also connect up with irc networks so if it fits better under network.irc I'll change and resubmit.

Related Objects
Search...

StatusSubtypeAssignedTask
 ResolvedBennZoidT1042 Riot
 ResolvedJoshStroblT2588 Riot 0.9.7 Initial commit

Event Timeline

BennZoid created this task.Feb 15 2017, 1:25 AM
JoshStrobl moved this task from Backlog to Awaiting Fixes on the Patch Submission board.Feb 23 2017, 12:24 AM
JoshStrobl added a subscriber: JoshStrobl.
  1. Your install calls install -D -d -m 00755 for directory creation should be: install -dm00644
  2. The desktop file doesn't need the Exec to have "/usr/bin/riot-web", it can just be riot-web (without quotes and absolute path).
  3. You don't have nodejs listed as a rundep, that'll need to happen (notice that it isn't marked as a used lib in abi_used_libs).
BennZoid added a comment.Feb 23 2017, 10:16 PM

I've update the patch here. Let me know if you see anything else and thanks for all the pointers!

0001-Initial-commit-of-riot.patch10 KBDownload

JoshStrobl claimed this task.Feb 23 2017, 10:26 PM
JoshStrobl moved this task from Awaiting Fixes to Ready For Merge on the Patch Submission board.

LGTM, nice work! I know nodejs stuff can be a PITA :)

JoshStrobl closed this task as Resolved.Feb 24 2017, 6:52 PM

Landed in unstable as of https://git.solus-project.com/packages/riot/commit/?id=9256488dcfb4ca2616e080564c65e0deccb21697

Also fixed the license in a subsequent commit as the license wasn't SPDX compatible.

Copyright © 2015-2021 Solus Project. The Solus logo is Copyright © 2016-2021 Solus Project. All Rights Reserved.