Page MenuHomeSolus

Riot 0.9.7 Initial commit
Closed, ResolvedPublic

Description

Took a run at packaging riot. Electron was a bit of a pain but I think I got it figured out.

Note: For component I placed this in network.im as riot works as a messaging app. It can also connect up with irc networks so if it fits better under network.irc I'll change and resubmit.

Related Objects

StatusSubtypeAssignedTask
ResolvedBennZoid
ResolvedJoshStrobl

Event Timeline

JoshStrobl added a subscriber: JoshStrobl.
  1. Your install calls install -D -d -m 00755 for directory creation should be: install -dm00644
  2. The desktop file doesn't need the Exec to have "/usr/bin/riot-web", it can just be riot-web (without quotes and absolute path).
  3. You don't have nodejs listed as a rundep, that'll need to happen (notice that it isn't marked as a used lib in abi_used_libs).

I've update the patch here. Let me know if you see anything else and thanks for all the pointers!

JoshStrobl moved this task from Awaiting Fixes to Ready For Merge on the Patch Submission board.

LGTM, nice work! I know nodejs stuff can be a PITA :)

Landed in unstable as of https://git.solus-project.com/packages/riot/commit/?id=9256488dcfb4ca2616e080564c65e0deccb21697

Also fixed the license in a subsequent commit as the license wasn't SPDX compatible.