Page MenuHomeSolus
Create Task
Maniphest T2431

Visual Studio Code OSS icon missing in most icon packs
Closed, ResolvedPublic
Actions

Description

vscode-oss.desktop defines the icon for VS Code to be "code-oss", which does not seem to be included in the majority of icon packs. Instead, most icon packs only include a "visual-stuido-code" icon.

Whilst having a different icon for different versions of VS Code may be desirable, the missing icon can cause an inconsistent look when using an icon pack which does not have a specific icon for the OSS version of VS Code (I'm not sure that the default theme in Solus even includes one?).

As I understand it, both the MS and OSS versions of VS Code used to be packaged for Solus, however it seems that the MS version has been removed and the OSS version is the only version available. As such, one possible solution may be to simply change the Icon for the OSS version to "visual-studio-code" icon which is much more common.

Details

Commits
R3148:decb6cd9f2c8: Change icon in desktop file to visual-studio-code to resolve T2431.

Related Objects

Event Timeline

JoshStrobl claimed this task.Feb 5 2017, 6:24 AM
JoshStrobl triaged this task as Low priority.
JoshStrobl added a project: Software.
JoshStrobl changed the task status from Open to In Progress.Feb 5 2017, 6:29 AM
JoshStrobl moved this task from Backlog to Improvement on the Software board.
whatever added a subscriber: whatever.Feb 16 2018, 6:41 AM
In T2431#42363, @JoshStrobl wrote:

Resolved in unstable as of https://git.solus-project.com/packages/vscode/commit/?id=decb6cd9f2c8061393a77ae249a635e76553f033

Icon still missing here on fresh install, and that link is 404-ing on me.

JoshStrobl added a comment.EditedFeb 16 2018, 7:48 AM

Icon still missing here on fresh install, and that link is 404-ing on me.

Because the link dates back to our old infrastructure. It was resolved via a pixmap (for KDE users) via R3148:e7d28522dc4ffdfb22d50a9364a39fb556791104 and it's supported in basically every other updated icon pack (papirus and moka, off the top of my head).

So yes, it's most certainly fixed. Wait until our next sync to stable.

Copyright © 2015-2021 Solus Project. The Solus logo is Copyright © 2016-2021 Solus Project. All Rights Reserved.