Page MenuHomeSolus
Create Task
Maniphest T2413

python-colorama
Closed, ResolvedPublic
Actions

Description

Here is a patch for python-colorama (both python and python3):

0001-Initial-commit-of-python-colorama.patch5 KBDownload

Event Timeline

W-Floyd created this task.Feb 4 2017, 1:49 AM
DataDrake added a subscriber: DataDrake.Feb 4 2017, 5:50 PM

What do we need this for?

W-Floyd added a comment.Feb 6 2017, 1:51 AM

It is required for socli, a Stack Overflow command line interface written in python. I understand socli has not been requested, but I do expect the python2 version of an existing python3 package would be reasonable.

DataDrake added a comment.Feb 18 2017, 1:53 AM

So, two things.

  1. You don't need to specify pkgconfig(python-2.7), as that is included automatically.
  2. If we are going to land this, we should retire python3-colorama in favor of a single package.
W-Floyd updated the task description. (Show Details)Feb 18 2017, 5:04 AM

Updated the patch. I'm not sure how to go about replacing a package, though I'm happy to learn :)

ikey added a subscriber: ikey.Feb 18 2017, 8:58 AM

There is no harm in pkgconfig(python-2.7) as python-devel will not be staying in system.devel after we switch to sol.
All replacements/obsoletes should involve me.

W-Floyd added a comment.Feb 18 2017, 10:18 AM

Okay, so should I just leave this to you then?

JoshStrobl claimed this task.Mar 11 2017, 12:38 AM
JoshStrobl added a subscriber: JoshStrobl.

@W-Floyd Hey, sorry for the delayed reply. Next time @ikey is around, I'll coordinate with him on deprecating python3-colorama.

JoshStrobl triaged this task as Normal priority.Mar 11 2017, 12:39 AM
JoshStrobl moved this task from Backlog to Ready For Merge on the Patch Submission board.
JoshStrobl closed this task as Resolved.Mar 21 2017, 11:55 AM

Landed in unstable as of your patch and a follow-up to do the replaces: https://git.solus-project.com/packages/python-colorama/commit/?id=c5a65f80b2993febb9a2541ecfeca257eac0b9fb

Coordinated with @ikey so now python3-colorama will be replaced with python-colorama. Apologies for the delay.

W-Floyd added a comment.Mar 21 2017, 11:57 AM

No worries about the delay, glad it got sorted :)

Copyright © 2015-2021 Solus Project. The Solus logo is Copyright © 2016-2021 Solus Project. All Rights Reserved.