Page MenuHomeSolus

Mpd (with systemd system unit)
Closed, ResolvedPublic

Description

Rebuild of Mpd (with Solbuild :) ) with systemd system unit enabled during building.

Event Timeline

sunnyflunk moved this task from Backlog to Awaiting Fixes on the Patch Submission board.
sunnyflunk added a subscriber: sunnyflunk.

Okay, so I clicked the patch, so I may as well provide some feedback:

  1. You deleted the Makefile...don't do that! If you update the common git directory then running make will use solbuild from now on (and also run the important abireport tool).
  2. You didn't increment the release number
  3. You use the directory /usr/lib Solus uses /usr/lib64 or %libdir%
  4. There's no abireport information contained (abi_* files), likely cause of 1 and running solbuild directly.

Thanks, I will review the building process tomorrow. Still have to familiarise with solbuild ans changes from Evobuild process ;)

That's should be good now, but I did not have any abi_report file, the build process has a make abireport line but nothing.

Makefile is pointing to a file in your $HOME, do echo "include ../Makefile.common" | tee Makefile in the package directory 😄

Thanks, I obviously fucked up my aliases config ^^

Just missed you on IRC, basically, if your environment (common) is updated and set up right, you should be able to run make in the directory, and it will

  1. Build the .eopkg files
  2. Run the make abireport report command (it's working correctly when you get the abi_used_libs file)

you should be able to run make in the directory, and it will

  1. Build the .eopkg files
  2. Run the make abireport report command (it's working correctly when you get the abi_used_libs file)
  1. The .eopkg buildin works
  2. make abireport seems to start working, but it ends with nothing.
[Package] Building complete
INFO[18:13:45] Collecting build artifact                     file="mpd-0.19.19-10-1-x86_64.eopkg"
INFO[18:13:45] Collecting build artifact                     file="pspec_x86_64.xml"
INFO[18:13:45] Cleaning up                                  
INFO[18:13:46] Requesting unmount of all remaining mountpoints 
INFO[18:13:47] Building succeeded                           
make[1] : on quitte le répertoire « /home/justin/Solbuild/mpd »
make abireport
make[1] : on entre dans le répertoire « /home/justin/Solbuild/mpd »
python3 "../."/common/Scripts/abireport.py `dirname package.yml`
make[1] : on quitte le répertoire « /home/justin/Solbuild/mpd »

@ikey found the culprit for not creating abi_used_lib file, French language is the one to blame here.

So now the patch should work ;)

Ok, last thing (pays to check the paths with lseopkg mpd-0.19.19-10-1-x86_64.eopkg

You need to add a slash to separate after %libdir%

+            <Path fileType="library">/usr/lib64systemd/system/mpd.service</Path>
+            <Path fileType="library">/usr/lib64systemd/system/mpd.socket</Path>

Now I'm 99,99% sure it will be a good patch ;)