Page MenuHomeSolus

Angband
Closed, ResolvedPublic

Description

Angband a free singel-player dungeon exploration game like rougelike and so on.

Event Timeline

crash created this task.Aug 12 2016, 11:43 AM

Few things:

  1. You have a newline between description and builddeps that needs to be removed.
  2. %autogen automatically runs %configure, so your flags should be passed there. Also I'd recommend reading the CONFOPTS defined here, since we already define sysconfdir and typically flags like bindir are already generated based on the prefix, with usr/share stuff usually being defined as via datadir, which we already set.
  3. Builddeps should be ascending sorted (A-Z).

Otherwise good work :)

crash updated the task description. (Show Details)Aug 16 2016, 9:03 AM
crash updated the task description. (Show Details)
crash added a comment.Aug 16 2016, 9:07 AM

Thank you for the info, it's always great to learn new things how to package :)

I have cleaned up the package.yml a bit, and i tried to specify in autogen instead but then i got build,target errors so i put them back in configure instead.

And i needed to specify --bindir aswell beacuse default it put it in /usr/share/games and then i could't start the game with out doing /usr/share/games/angband. but now i can just run it from the commandline.

Ow. Gotta love those terribly written autotools stuff right?

crash added a comment.Aug 16 2016, 3:08 PM

Yeah this game was harder then i thought in the beginning :) it's a small game size wise hehe.

JoshStrobl changed the task status from Open to In Progress.Aug 23 2016, 7:49 PM
JoshStrobl claimed this task.
crash added a comment.Aug 23 2016, 9:34 PM

Thanks for merging it in :) ah i see you changed so autogen took care if instead of configure.