Page MenuHomeSolus

zpaq
Closed, ResolvedPublic

Description

Here is a patch for zpaq.

Event Timeline

Why is the Makefile patch needed? From what I can tell, the only thing you're doing is changing PREFIX, which you can do by simply calling PREFIX=/usr after your make and make install macros.

JoshStrobl triaged this task as Normal priority.Nov 24 2016, 6:05 AM
JoshStrobl moved this task from Ready For Merge to Awaiting Fixes on the Patch Submission board.

Ah, my bad! I misunderstood how Makefiles worked, thanks for pointing that out. Fixed :)

I have a couple of comments:

  1. I see some of the code is MIT licensed (from website, from COPYING file and from the source code file) as well as the Unlicensed one
  2. Looking at the Makefile, it makes the flags '-O3 -march=native' <- should never use native for a repo build as it won't run on older processors