Page MenuHomeSolus

Gutenprint
Closed, ResolvedPublic

Description

Rebuild of Gutenprint against CUPS to make sure PPD files for printers provided by Gutenprint are usable in CUPS.

Event Timeline

BridouZ created this task.Aug 3 2016, 5:53 PM
diff --git a/package.yml b/package.yml
new file mode 100644
index 0000000..2ecfb4a
--- /dev/null
+++ b/package.yml

Why is this a new file? This should be a patch against the existing package.yml

+component  : PLEASE FILL ME IN

It means it. :)

So patch issues aside, what are you actually trying to change here? The patch doesn't explain it. Also I think you mean PPD not PPA :D

BridouZ added a comment.EditedAug 3 2016, 7:29 PM

Yeah sorry, seems that I did not review the patch befor uploading it.

In fact gutenprint in the repo is not build with the --enable-cups-ppds for the setup part and it leads to an issue with showing gutenprint's ppds in cups.

I don't understant how to patch against the existing package.yml, do I have to clone the repo, make modificatons on files and rebuild the whole thing ? Sorry not an expert packager but I'm learning :)

EDIT: New patch file, clone from Solus repo, modified and patched.

 ⚙ ikey@solus-bdw  ~/Solus/gutenprint   master  git am 0001-Rebuild-gutenprint-against-cups-and-enable-cups-vari.patch
Applying: Rebuild gutenprint against cups and enable cups variables for configuration in order to use generated PPDs within Cups resulting in adding printers.
.git/rebase-apply/patch:30: trailing whitespace.
    The Gutenprint (formerly Gimp-Print) package contains high quality drivers for many brands and models of printers 
.git/rebase-apply/patch:52: trailing whitespace.
        <Description xml:lang="en">The Gutenprint (formerly Gimp-Print) package contains high quality drivers for many brands and models of printers 
.git/rebase-apply/patch:61: trailing whitespace.
        <Description xml:lang="en">The Gutenprint (formerly Gimp-Print) package contains high quality drivers for many brands and models of printers 
.git/rebase-apply/patch:2717: trailing whitespace.
        <Description xml:lang="en">The Gutenprint (formerly Gimp-Print) package contains high quality drivers for many brands and models of printers 
error: component.xml: already exists in index
error: patch failed: package.yml:4
error: package.yml: patch does not apply
error: patch failed: pspec_x86_64.xml:2
error: pspec_x86_64.xml: patch does not apply
Patch failed at 0001 Rebuild gutenprint against cups and enable cups variables for configuration in order to use generated PPDs within Cups resulting in adding printers.
The copy of the patch that failed is found in: .git/rebase-apply/patch
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

This patch doesn't apply.. ?

OK, it sounds like I do not understand how to create a patch from an existing repo ....

Clone our existing gutenprint repo and make sure its up to date
Then just make changes to those existing files, commit the changes and git format-patch -1, simples :D

mfossen added a subscriber: mfossen.EditedAug 4 2016, 4:10 AM

If it helps, I found this guide to be really useful:

https://wiki.solus-project.com/Packaging_Quick_Start_Guide

Then, after you get through the "Setup Git" section of the guide:

Basically, git clone what you want from git.solus-project.com, make your changes in package.yml.

Now, make sure it builds by typing make

It works? Good, now git add package.yml pspec_x86_64.xml

Then, git commit -m "These are my changes"

Finally, git format-patch -1 and give the resulting patch file a look to see if anything obviously wrong stands out.

@mfossen thanks - much better explanation ^^

@mfossen Thanks for the guide, I think it's good now

ikey closed this task as Resolved.Aug 4 2016, 8:03 PM
ikey claimed this task.

This is now merged in the repo, thank you very much! Gonna make many folks happy =)

Wow so much more printing support! You're amazing :D