Page MenuHomeSolus
Create Task
Maniphest T1560

httrack
Closed, ResolvedPublic
Actions

Description

This is a simple and powerful website cloning tool for making offline backups.

0001-Initial-commit-of-httrack.patch7 KBDownload

Event Timeline

BearzR created this task.Nov 13 2016, 2:19 PM
DataDrake moved this task from Backlog to Awaiting Fixes on the Patch Submission board.Nov 13 2016, 3:37 PM
DataDrake added a subscriber: DataDrake.

Ok so this mostly looks good. I have one minor fix that I need to see. The license should be GPL-3.0 not GNU-3. Licenses should follow the identifiers presented here: https://spdx.org/licenses/

DataDrake triaged this task as Normal priority.Nov 13 2016, 3:38 PM
BearzR added a comment.Nov 13 2016, 4:43 PM

Sorry about that.

0001-Initial-commit-of-httrack.patch7 KBDownload

JoshStrobl added a subscriber: JoshStrobl.Nov 13 2016, 8:17 PM

You need to disable static libraries and fix your spelling mistake in description ("powerfull"). Otherwise LGTM.

BearzR added a comment.Nov 14 2016, 8:15 PM

0001-Initial-commit-of-httrack.patch6 KBDownload

JoshStrobl added a comment.Nov 14 2016, 9:00 PM

--enable-static=no You should be able to just pass --disable-static.

BearzR added a comment.Nov 14 2016, 10:33 PM

Here is the patch with the desired changes.

0001-Initial-commit-of-httrack.patch6 KBDownload

JoshStrobl claimed this task.Nov 14 2016, 10:58 PM
JoshStrobl moved this task from Awaiting Fixes to Ready For Merge on the Patch Submission board.

LGTM. Thank you for the fixes!

JoshStrobl closed this task as Resolved.Nov 14 2016, 11:02 PM

Landed in unstable as of https://git.solus-project.com/packages/httrack/commit/?id=c5116353c01cd984bbae975a9c88456b09b8f51c

Copyright © 2015-2021 Solus Project. The Solus logo is Copyright © 2016-2021 Solus Project. All Rights Reserved.