This packages brogue. Needs libtcod first. This took some work, and I based it off the AUR package. I patched brogue to not use the bundled libtcod, as well as to throw in their fonts into an absolute path. There's probably a cleaner way to do the fonts path patch.
Description
Description
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Resolved | subpop | T1295 Brogue | |||
| Resolved | JoshStrobl | T1555 brogue | |||
| Resolved | JoshStrobl | T1554 libtcod |
Event Timeline
Comment Actions
+summary :
Add a summary. Right now it is empty.
+builddeps : + - sdl1-devel + - libtcod-devel + - sed + - desktop-file-utils
Need to use pkgconfigs, check what component things are in (ex. sed, which is system.base).
+setup : | + %patch -p0 < $pkgfiles/use-system-tcod.patch + %patch -p0 < $pkgfiles/use-system-data-dir.patch + %patch -p0 < $pkgfiles/fix-desktop-file.patch
Should use a series file instead and %apply_patches. Documentation here.
Your install calls need to be fixed, eliminate the redundant directory creation when you're doing things like binary installing. Use 00 before permissions to ensure there is no setuid and sticky bits, combine flags. Drop %prefix% similar to what I stated in your libtcod patch, just use /usr.
+ %make clean
This shouldn't be necessary. Each chroot is a clean env.
Comment Actions
Updated patch with suggestions from comments above.
Note
- I did not test this build in an evobuild chroot. Since libtcod isn't available in the solus repos, brogue does not build in evobuild. It builds locally using ypkg.
- I left %make clean in because the only source archives I could find include precompiled binaries. I would rather clean those out and build into an empty source dir.
Comment Actions
Not sure you uploaded the right patch, because none of what I mentioned was addressed.
Comment Actions
I'll pass the patch but I'm going to do a post-merge patch to change desktop-file-install --dir=$installdir/usr/share/applications -m 00644 brogue.desktop to install -Dm00644 brogue.desktop $installdir/usr/share/applications/brogue.desktop and drop install -d $installdir/usr/share/applications. Please do the install bit in the future.
Comment Actions
Will do. I recall desktop-file-install validates the .desktop file before installing it, so rather than validating the file separately, and then installing it using install, I just used desktop-file-install to validate & install the .desktop file.
Comment Actions
Resolved with your patch and follow-up: https://git.solus-project.com/packages/brogue/commit/?id=bc0515a8bdcca5eb23861d62e0f38e3577434381
Thanks again :)