Pretty self explanatory: patch submission for yadm
Description
Description
Event Timeline
Comment Actions
- Remove the # CHECK ME from the license bit if you've verified what the license is.
- Why is git a builddep. I'm seeing no indication as to why it is needed, given you're just installing two files. If it needs git to run, then that'd be a rundep, not a builddep.
- Don't use mkdir and move. Use install.
- This is more of a system.utils than a programming.tools.
Comment Actions
- For the binary install call, should pass -Dm00755
- For man install call, should pass -Dm000644.
- Preferably use $workdir and $installdir instead of %workdir% and %installroot%
Otherwise the changes look good to me :) Nice work.
Comment Actions
Soooo...here's the update with the suggestions. If I may ask, why do you prefer to use $installdir over %installroot%? The password-store package uses the latter (I used it as the template for this patch btw).
Comment Actions
The password-store package uses the latter (I used it as the template for this patch btw).
Was a recently stylizing decision that we've been enforcing last few months. Please change it, as requested.
Comment Actions
Submitted a new task with the update. I also removed component.xml in favor of component in package.yml
Comment Actions
Not quite what I meant by "Please change it, as requested.", I was talking about your patch :P
Comment Actions
Why do I always forget to actually attach the ONE thing I absolutely need to? (thinking out loud)