Page MenuHomeSolus

neofetch won't display images
Closed, ResolvedPublic

Description

When trying to display images in the place of a logo (example from a neofetch github page), it opens an image editor instead of showing the image.

Steps to reproduce:

  1. Type in terminal:
$ neofetch --image /path/to/image/

Upd: Yep, it's a dependency problem. Creating a subtask for w3m.

Upd2: Also, I think that imagemagick, xwininfo and xprop should also be included as the dependencies.

Related Objects

StatusAssignedTask
ResolvedDataDrake
ResolvedDataDrake

Event Timeline

I can't find some dependencies neofetch needs in Solus repos, maybe that's the reason it does not work?

underskore renamed this task from neofetch can't display images to neofetch won't display images .Oct 29 2016, 10:53 AM
underskore updated the task description. (Show Details)Oct 29 2016, 1:57 PM
underskore updated the task description. (Show Details)Oct 29 2016, 2:05 PM
JoshStrobl triaged this task as Wishlist priority.Oct 29 2016, 7:24 PM
JoshStrobl moved this task from Backlog to Improvement on the Software board.
JoshStrobl edited subtasks, added: T1215: w3m; removed: T1360: w3m.Oct 31 2016, 7:15 PM
DataDrake closed subtask T1215: w3m as Resolved.Nov 5 2016, 7:09 PM
This comment was removed by underskore.

It kinda works in urxvt, but it doesn't in gnome-terminal, even though it should. Guess the issue still exists, so the task should probably be reopened.

DataDrake added a subscriber: Zero.Nov 6 2016, 12:09 AM

Works fine in urxvt. @Zero is working on a patch for w3m to provide image support for gnome-terminal. This won't work for gnome-terminal out of the box. It never has.

underskore added a comment.EditedNov 6 2016, 12:13 AM

@Zero is working on a patch for w3m to provide image support for gnome-terminal. This won't work for gnome-terminal out of the box. It never has.

Oh, great. By the way, --ascii-distro also doesn't work like it should (used ubuntu for this example)

Edit: Nevermind, it's just the image mode.

dylanaraps added a subscriber: dylanaraps.EditedNov 7 2016, 7:51 PM

Hello,

@DataDrake, your fix is pointless because neofetch has a function that finds the w3m-img location automatically. The function getw3m_img_path() checks to see if w3m-img is installed in these locations:

  • /usr/lib/w3m/w3mimgdisplay
  • /usr/libexec/w3m/w3mimgdisplay
  • /usr/lib64/w3m/w3mimgdisplay
  • /usr/libexec64/w3m/w3mimgdisplay

The config file option is *meant* to be there for the user to manually specify a custom location if the function above fails to find w3m-img. I should update the docs to make this clearer.

This won't work for gnome-terminal out of the box. It never has.

w3m-img works in Gnome-terminal on my system.

I'd prefer it if you didn't randomly add patches, I'd rather we get the issue solved upstream so that it works for everyone.

I'd also prefer it if you directed all bug reports upstream so that I can actually fix them.

Note: I can't fix the issues in this thread tracker if I don't know they exist.

Note2: Neofetch 1.9.1 was released 4 days ago and has some fixes for Budgie theme/icons detection.

Thanks

I'd prefer it if you didn't randomly add patches, I'd rather we get the issue solved upstream so that it works for everyone.

Some of this is Solus-specific integration. None of it is "random".

Note2: Neofetch 1.9.1 was released 4 days ago and has some fixes for Budgie theme/icons detection.

These are Budgie issues, not Solus integration. I'll comment on the other issues on https://github.com/dylanaraps/neofetch/issues/408