Page MenuHomeSolus
Create Task
Maniphest T1141

mate-menu
Closed, ResolvedPublic
Actions

Description

0001-Initial-commit-to-mate-menu.patch7 KBDownload

Event Timeline

blaz created this task.Oct 18 2016, 7:35 PM
JoshStrobl triaged this task as Normal priority.Oct 24 2016, 5:13 PM
JoshStrobl moved this task from Backlog to Awaiting Fixes on the Patch Submission board.
JoshStrobl added subscribers: ikey, JoshStrobl.
+setup      : |
+    %python_setup
+build      : |
+

Please either:
a. Drop setup and move python_setup macro to build.
b. (or) Drop the build section. Since it isn't used.

Otherwise LGTM but concerned with it landing in desktop.mate and thus being automatically installed whenever someone opts to try MATE via a Budgie image. Has this gotten our benevolent @ikey's approval?

blaz added a comment.Oct 24 2016, 8:35 PM

0001-Initial-commit.patch7 KBDownload

I don't have the bot... boss' approval, but mate-sensors-applet isn't used in the default panel setup and is a part of desktop.mate. Similarly, screenshot-applet and haste-applet are in desktop.budgie.

JoshStrobl moved this task from Awaiting Fixes to Ready For Merge on the Patch Submission board.Oct 24 2016, 8:45 PM

I didn't ask for your common sense good sir.

Ya okay this'll go in. Patch looks good to me!

ikey added a comment.Oct 24 2016, 8:47 PM

I don't have the bot... boss' approval

He sees all! But yeah desktop.mate is fine, people can fine-tune after :)

blaz added a comment.Oct 24 2016, 8:55 PM
In T1141#21144, @ikey wrote:

I don't have the bot... boss' approval

He sees all!

?

JoshStrobl closed this task as Resolved.Oct 28 2016, 4:56 PM
JoshStrobl claimed this task.

Landed in unstable as of https://git.solus-project.com/packages/mate-menu/commit/?id=ba6677b0f96555a4be31b8a4f2c017a0e4bb00ec

Thanks!

Copyright © 2015-2021 Solus Project. The Solus logo is Copyright © 2016-2021 Solus Project. All Rights Reserved.