Page MenuHomeSolus

Sonivox libraries required by newer versions of drumstick
Closed, ResolvedPublic

Description

Older versions of drumstick have been using a bundled and statically linked version of Sonivox libraries, but on the newer versions it's an external dependency which Solus repositories haven't got.

https://github.com/pedrolcl/sonivox
https://github.com/pedrolcl/sonivox/archive/refs/tags/v3.6.11.tar.gz

Revisions and Commits

Event Timeline

algent added a subscriber: algent.

I think this is OK for inclusion. Normally if an existing package requires a new dependency there is no need to request it for inclusion.

algent triaged this task as Normal priority.Dec 17 2022, 6:19 PM

I think this is OK for inclusion. Normally if an existing package requires a new dependency there is no need to request it for inclusion.

Doesn't it need a repo construction by someone with adequate permissions, though? I might be misremembering.

Doesn't it need a repo construction by someone with adequate permissions, though? I might be misremembering.

Yes, but you can submit a diff for a non-existent repo. The person merging your stack will just create the corresponding repo when they accept/land your diff.

Something like this usually works:

mkdir newpackage && cd newpackage
git init && git switch -c master
git commit -m "Initial commit" --allow-empty
git remote add origin https://dev.getsol.us/source/newpackage.git

And then you can populate the directory with a makefile and package.yml and you should be off to the races. If arc diff asks just hit enter to accept the default selection of origin/master (idk what the exact question it asks is, been a bit since I've done this).

Note that changing the default branch to master is important, you'll have to fix your commit after you submit your diff if you forget that step.

Very comprehensive response, thanks!

If arc diff asks just hit enter to accept the default selection of origin/master (idk what the exact question it asks is, been a bit since I've done this).

fatal: Not a valid object name origin/master

I assume this is because the remote doesn't exist yet.