Page MenuHomeSolus

rclone .patch
Closed, ResolvedPublic

Description

Event Timeline

  1. Needs to use their release tarballs, not git commits.
  2. Don't use network.base, that means it'll be installed onto everyone's machines. Please use network.util.
  3. Any particular reason why a faux workspace is being created rather than just setting the workdir as the Go path?
  4. # Have to set the GOPATH again, I don't knwo why,but it has probably something to do how eopkg works. can be removed. It isn't anything to do with eopkg, it's ypkg and evobuild stuff. Exporting vars on individual steps is normal.
  5. Drop the first two redundant install commands and read what -D does :) Prepend them to the flags on the binary and manual file installation.
  1. I already talked about this with the Author, i guess there will be a new release soon.
  2. Okay, changed it.
  3. You are right this is a loot simpler
  4. Okay, thanks didn't knew this
  5. Didn't quit get what you mean with "Prepend them to the flags on the binary and manual file installation."

I'll update this patch as soon as there is a new release.

I already talked about this with the Author, i guess there will be a new release soon.

What? They have a releases section, with tarballs. Click the Releases link on https://github.com/ncw/rclone and you'll see the versioned tarballs.

Yes, i know, the problem is that the latest release is broken, that is why i used a commit as source.

Yes, i know, the problem is that the latest release is broken, that is why i used a commit as source.

The more accepted practice is to use latest tarball then apply patches based on git commits that resolve said issue (or to indeed wait for next release).

JoshStrobl triaged this task as Normal priority.Oct 11 2016, 4:55 PM

Updated the .patch
Not sure if I made the .patch for building right, but it works, maybe someone can have a look on it.

Yea that patch doesn't look right at all. Should really only include the files that changed, not what looks like every single file between the latest version and master.

So I should only make the git diff between the release and the commit with the fix?
I downloaded the realease 1.33 and the master.
And than I used this command "git diff rclone-1.33/ rclone/"

I think we should just wait a little longer for the next release rather than patching in all of master. I'm still unsure why you couldn't just do the 1.33 release for now.

1.33 release uses and old API for google drive.

Then I stand by my statement. We should wait for the next release.

Rclone 1.34 released a few days ago, and now it is working :)