Page MenuHomeSolus

Request: build 'mpv' with meson instead of waf
Closed, InvalidPublic

Description

I'd like to request that the build system for mpv (R2107) be switched from waf to meson.

Why? mpv is a great minimal media player commonly used in window managers. It works great in i3, but does not work in sway as it needs to be built with meson in order to support wayland. I know I'm in the minority for this use-case, but barring any benefits to building with waf over meson, hoping this wouldn't be a problem.

@Staudey thoughts?

Event Timeline

I just happened to build the latest release (because it coincided with our necessary switch from youtube-dl to yt-dlp), so I think other people can give a more informed opinion on this.

Meson support is not part of a release yet, so this will have to wait a little

Edit: Got the latest git building with meson. No gotchas aside from our stateless patch, which I don't know how to properly fix.

Plain mpv already works fine on Sway, gnome-mpv does not, meson build of mpv does not change this. Perhaps gnome-mpv needs a rebuild

Aside from what have been said, mpv has supported Wayland for a long time, and we have built it wth Wayland support already. It's likely that your issue with mpv on Wayland isn't connected to the build system.

Thanks @davidjharder @aleksvor, I'm not using gnome-mpv but good to know regular mpv is built to support wayland. I'll figure out the issue on my end.

Update: adding the following to my mpv.conf does the trick for wayland + hardware acceleration:

hwdec=vaapi-copy
vo=gpu
gpu-context=wayland

ytdl-format=bestvideo[vcodec!=?vp9]+bestaudio/best

JoshStrobl added a subscriber: JoshStrobl.

Given it isn't part of a release yet and MPV already works on Wayland, don't really see a reason this needs to be an open task. Moving to better build systems like Meson is a natural process during packaging and package maintenance.