Initial commit of kodi, to fulfill T51: Kodi
Thanks again to ikey for fixing some of the blocking issues I was having and for the super nice to work with packaging system.
mfossen | |
Aug 8 2016, 4:10 AM |
F435: 0001-Update-to-17.0.patch | |
Aug 8 2016, 4:45 AM |
F434: 0001-Initial-Commit.patch | |
Aug 8 2016, 4:10 AM |
Initial commit of kodi, to fulfill T51: Kodi
Thanks again to ikey for fixing some of the blocking issues I was having and for the super nice to work with packaging system.
OK so, there is an existing package.yml pspec etc in that git repo: https://git.solus-project.com/packages/kodi/
Not entirely sure if this should be against that package.. feel it should be.
- pkgconfig(libavformat) - pkgconfig(libavfilter) - pkgconfig(libavcodec) - pkgconfig(libavutil) - pkgconfig(libavresample) - pkgconfig(libswresample) - pkgconfig(libswscale) - pkgconfig(libpostproc) - pkgconfig(libavdevice)
These are all in the same package, ffmpeg-devel. Best to just use a single pkgconfig(libavformat) here to to speed up dependency resolution of the builds.
More dupes:
- pkgconfig(libva) - pkgconfig(libva-x11)
And the final change we need, is to clear up all the trailing whitespace in the patch, you'll see it marked red in git show:
✘ ikey@solus-bdw ~/Solus/kodi master git am 0001-Initial-Commit.patch Applying: Initial Commit .git/rebase-apply/patch:19: trailing whitespace. license : GPL-2.0 .git/rebase-apply/patch:59: trailing whitespace. - pkgconfig(libavformat) .git/rebase-apply/patch:60: trailing whitespace. - pkgconfig(libavfilter) .git/rebase-apply/patch:62: trailing whitespace. - pkgconfig(libavutil) .git/rebase-apply/patch:63: trailing whitespace. - pkgconfig(libavresample) warning: squelched 3 whitespace errors warning: 8 lines add whitespace errors
Great start though, super impressed =)
Don't be sorry - all part of the process :D Really appreciate you stepping up like this and improving Solus - means a lot to all of us
Good to hear! Glad I could help, and I've said it already but thanks again for your help through this tougher patch, I would've been totally lost otherwise.